[PATCH v3 4/7] cmd: fru: add product info area parsing support

Simon Glass sjg at chromium.org
Thu Aug 25 17:08:19 CEST 2022


Hi Jae,

On Thu, 25 Aug 2022 at 08:33, Jae Hyun Yoo <quic_jaehyoo at quicinc.com> wrote:
>
> Hi Simon,
>
> On 8/24/2022 6:25 PM, Simon Glass wrote:
> > Hi Jae,
> >
> > On Tue, 23 Aug 2022 at 14:53, Jae Hyun Yoo <quic_jaehyoo at quicinc.com> wrote:
> >>
> >> Add product info area parsing support. Custom board fields can be
> >> added dynamically using linked list so that each board support can
> >> utilize them in their own custom way.
> >>
> >> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo at quicinc.com>
> >> ---
> >> Changes from v2:
> >>   * Changed 'struct fru_board_info_member' to 'struct fru_common_info_member'.
> >>
> >> Changes from v1:
> >>   * Refactored using linked list instead of calling a custom parsing callback.
> >>
> >> Changes from RFC:
> >>   * Added manufacturer custom product info fields parsing flow.
> >>
> >>   cmd/fru.c     |  28 ++++--
> >>   include/fru.h |  34 ++++++-
> >>   lib/fru_ops.c | 244 +++++++++++++++++++++++++++++++++++++++++++++++---
> >>   3 files changed, 286 insertions(+), 20 deletions(-)
> >>
> >
> > Please add tests for this code.
>
> I already added c and python version unit test scripts in this series.

Yes, I saw them later, thanks.

Regards,
Simon


More information about the U-Boot mailing list