[PATCH] disk: part: remove dependency to ubifs for spl

Heinrich Schuchardt xypron.glpk at gmx.de
Mon Aug 29 17:01:08 CEST 2022


On 8/8/22 16:45, Stefan Herbrechtsmeier wrote:
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
>
> The spl doesn't support ubifs and thereby doesn't provide the
> ubifs_is_mounted function. Remove the dependency to ubifs for the spl.
>
> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
>
> ---
>
>   disk/part.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/disk/part.c b/disk/part.c
> index 79955c7fb0..de1b917e84 100644
> --- a/disk/part.c
> +++ b/disk/part.c
> @@ -479,7 +479,7 @@ int blk_get_device_part_str(const char *ifname, const char *dev_part_str,
>   	}
>   #endif
>
> -#ifdef CONFIG_CMD_UBIFS
> +#if IS_ENABLED(CONFIG_CMD_UBIFS) && !IS_ENABLED(CONFIG_SPL_BUILD)

This configuration seems strange. The support for a file system should
not depend on a command. I think a CONFIG_UBIFS is missing.

Best regards

Heinrich

>   	/*
>   	 * Special-case ubi, ubi goes through a mtd, rather than through
>   	 * a regular block device.



More information about the U-Boot mailing list