[PATCH 1/1] efi_loader: fix handling of DHCP acknowledge

[Ilias Apalodimas]

Hi Henrich

On Wed, 30 Nov 2022 at 14:45, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> On 11/30/22 09:44, Ilias Apalodimas wrote:
> > On Wed, Nov 30, 2022 at 08:50:07AM +0100, Heinrich Schuchardt wrote:
> >>
> >>
> >> On 11/30/22 08:37, Ilias Apalodimas wrote:
> >>> Hi Heinrich,
> >>>
> >>> On Sat, Nov 26, 2022 at 05:10:56PM +0100, Heinrich Schuchardt wrote:
> >>>> The dhcp command may be executed after the first UEFI command.
> >>>> We should still update the EFI_PXE_BASE_CODE_PROTOCOL.
> >>>>
> >>>> Don't leak content of prior acknowledge packages.
> >>>>
> >>>> Handle out of memory.
> >>>>
> >>>
> >>> The patch looks correct, but the description is a bit confusing.  Apart
> >>> from what you mention this patch also fixes
> >>
> >>> - An unchecked allocation
>
> Above I wrote "Handle out of memory."

ah, well that wasn't too clear when I first read the commit message.
Can you please amend ti while merging?

Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>

>
> Regards
>
> Heinrich
>
>
> >>
> >> I can add this.
> >>
> >>> - shadowing of the global netobj
> >>
> >> netobj was a local variable before this patch.
> >>
> >
> > Ah missed that
> >
> > Thanks!
> > /Ilias
> >> Thanks for reviewing.
> >>
> >> Best regards
> >>
> >> Heinrich
> >>
> >>> Can we please update the commit message to something that mentions all of
> >>> these?
> >>>
> >>> Thanks
> >>> /Ilias
>