[PATCH] mtd: spi-nor-core: Invert logic to reflect sst26 flash unlocked

Michal Simek monstr at monstr.eu
Mon Dec 5 10:02:25 CET 2022


út 22. 11. 2022 v 6:19 odesílatel Ashok Reddy Soma
<ashok.reddy.soma at amd.com> napsal:
>
> From: Algapally Santosh Sagar <santoshsagar.algapally at amd.com>
>
> flash_is_locked is changed to flash_is_unlocked with commit 513c6071ce73
> ("mtd: spi: Convert is_locked callback to is_unlocked"). sst26_is_locked()
> is also changed to sst26_is_unlocked() but the logic remained same.
> Invert the logic for the flash lock/unlock to work properly.
>
> Signed-off-by: Algapally Santosh Sagar <santoshsagar.algapally at amd.com>
> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma at amd.com>
> ---
>
>  drivers/mtd/spi/spi-nor-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi/spi-nor-core.c b/drivers/mtd/spi/spi-nor-core.c
> index 78de3c5281..1ea8363d9f 100644
> --- a/drivers/mtd/spi/spi-nor-core.c
> +++ b/drivers/mtd/spi/spi-nor-core.c
> @@ -1600,7 +1600,7 @@ static int sst26_is_unlocked(struct spi_nor *nor, loff_t ofs, uint64_t len)
>         ofs -= ofs & (SZ_64K - 1);
>         len = len & (SZ_64K - 1) ? (len & ~(SZ_64K - 1)) + SZ_64K : len;
>
> -       return sst26_lock_ctl(nor, ofs, len, SST26_CTL_CHECK);
> +       return !sst26_lock_ctl(nor, ofs, len, SST26_CTL_CHECK);
>  }
>
>  static int sst_write_byteprogram(struct spi_nor *nor, loff_t to, size_t len,
> --
> 2.17.1
>

Applied.
M

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs


More information about the U-Boot mailing list