[PATCH] rockchip: Pinebook Pro: Do not initialize i2c before relocation

[Peter Robinson]

On Sat, Dec 3, 2022 at 12:31 PM Michal Suchanek <msuchanek at suse.de> wrote:
>
> The i2c locks up when initialized before relocation, and it stays broken
> in Linux as well breaking the ability to boot Linux.
>
> The i2c bus and pmic was not actually used in pre-reloc before
> commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
>
> The cause is not known.
>
> This is board-specific, other boards that do not add the option to
> include the i2c bus in pre-reloc DT are not affected.
>
> Signed-off-by: Michal Suchanek <msuchanek at suse.de>

Reviewed-by: Peter Robinson <pbrobinson at gmail.com>
Tested-by: Peter Robinson <pbrobinson at gmail.com>

Thanks for checking this out, I had noticed a regression and had got
as far as bisecting it but not getting to a fix.

Tom: can we get this pulled into 2023.01 please?

Peter

> ---
>
> This is not tested, my board does not currentl;y boot at all, YMMV
> ---
>  arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> index 2d87bea933..fd87102c0b 100644
> --- a/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> +++ b/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi
> @@ -20,14 +20,6 @@
>         rockchip,panel = <&edp_panel>;
>  };
>
> -&i2c0 {
> -       u-boot,dm-pre-reloc;
> -};
> -
> -&rk808 {
> -       u-boot,dm-pre-reloc;
> -};
> -
>  &sdhci {
>         max-frequency = <25000000>;
>         u-boot,dm-pre-reloc;
> --
> 2.38.1
>