[PATCH v4 0/7] binman: rockchip: Migrate from rockchip SPL_FIT_GENERATOR script

Simon Glass sjg at chromium.org
Wed Dec 7 19:10:51 CET 2022


Hi Quentin,

On Wed, 7 Dec 2022 at 23:19, Quentin Schulz
<quentin.schulz at theobroma-systems.com> wrote:
>
> Hi Simon,
>
> On 12/7/22 02:08, Simon Glass wrote:
> > Hi Kevar,
> >
> > On Mon, 7 Nov 2022 at 11:40, Simon Glass <sjg at chromium.org> wrote:
> >>
> >> At present rockchip 64-bit boards make use of a FIT-generator script
> >> written in Python. The script supports splitting an ELF file into several
> >> 'loadable' nodes in the FIT. Binman does not current support this feature.
> >>
> >> This series adds binman support for ELF splitting. This works by adding a
> >> new 'fit,operation' property to the FIT subnodes, allowing this new way of
> >> generating nodes.
> >>
> >> Some other fixes and improvements are needed along the way.
> >>
> >> A new, common binman description is added for 64-bit boards which includes
> >> the required u-boot.itb file.
> >>
> >> The existing script is removed, so that only a few zynq boards are now
> >> using a SPL_FIT_GENERATOR script:
> >>
> >>     avnet_ultrazedev_cc_v1_0_ultrazedev_som_v1_0
> >>     xilinx_zynqmp_virt
> >>
> >> Migration of those is hopefully in progress.
> >>
> >> Note however that tools/k3_fit_atf.sh remains, used by a few boards that
> >> enable CONFIG_TI_SECURE_DEVICE so this series is copied there too:
> >>
> >>      am335x_hs_evm
> >>      am335x_hs_evm_uart
> >>      am43xx_hs_evm
> >>      am57xx_hs_evm
> >>      am57xx_hs_evm_usb
> >>      am65x_hs_evm_a53
> >>      am65x_hs_evm_r5
> >>      dra7xx_hs_evm
> >>      dra7xx_hs_evm_usb
> >>      j721e_hs_evm_a72
> >>      j721e_hs_evm_r5
> >>      k2e_hs_evm
> >>      k2g_hs_evm
> >>      k2hk_hs_evm
> >>      k2l_hs_evm
> >>
> >> Ivan Mikhaylov has sent a patch to help with these, but I need to take a
> >> look at the testing side. In any case they should really be using binman
> >> for the image generation.
> >>
> >> Changes in v4:
> >> - Add new patch to disable USE_SPL_FIT_GENERATOR by default
> >>
> >> Changes in v3:
> >> - Add an offset to the FIT description
> >> - Add support for writing sections in binman
> >> - Rebase to master
> >>
> >> Changes in v2:
> >> - Rename op-tee to tee-os
> >> - Drop use of .itb2
> >> - Drop patches previously applied
> >> - Add various suggestions from Alper Nebi Yasak
> >> - Add patches to refactor binman's FIT support
> >>
> >> Simon Glass (7):
> >>    binman: Allow writing section contents to a file
> >>    rockchip: evb-rk3288: Drop raw-image support
> >>    rockchip: Include binman script in 64-bit boards
> >>    rockchip: Support building the all output files in binman
> >>    rockchip: Convert all boards to use binman
> >>    rockchip: Drop the FIT generator script
> >>    treewide: Disable USE_SPL_FIT_GENERATOR by default
> >>
> >
> > Can this one please be applied in time for the release?
> >
>
> You still have review/questions left unanswered/unaddressed:
> https://lore.kernel.org/u-boot/a29f8d62-c7be-60e7-8a79-b52f589a93e7@linaro.org/
> https://lore.kernel.org/u-boot/67717a66-13d5-a72c-a34c-fac191a238ad@theobroma-systems.com/
> https://lore.kernel.org/u-boot/67717a66-13d5-a72c-a34c-fac191a238ad@theobroma-systems.com/

Oh I see. I did v5 but never sent it out! Thanks for noticing it. I
will get it out soon.

Regards,
Simon


More information about the U-Boot mailing list