[PATCH v4 1/2] x86: fsp: Only compile fsp_save_s3_stack if (SPL_)DM_RTC is enabled

Tom Rini trini at konsulko.com
Fri Dec 9 23:54:32 CET 2022


On Tue, Nov 22, 2022 at 12:54:51PM -0500, Sean Anderson wrote:

> This function calls rtc_write32, which has a different signature
> depending on if (SPL_)DM_RTC is enabled or not. This could result in a
> mismatch in SPL if DM_RTC was enabled but SPL_DM_RTC, as the non-DM
> declaration would still be used in SPL even though the implementation
> would be for non-DM_RTC. We are switching to the correct definitions in
> the next commit, so this will become a compilation error. Since
> fsp_save_s3_stack is not called from SPL, avoid compiling it if
> (SPL_)DM_RTC is disabled.
> 
> Signed-off-by: Sean Anderson <sean.anderson at seco.com>

Applied to u-boot/next, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20221209/22b7be63/attachment.sig>


More information about the U-Boot mailing list