[u-boot][PATCH 00/14] rawnand: omap_gpmc: driver model support

Roger Quadros rogerq at kernel.org
Mon Dec 12 10:12:07 CET 2022


Hi Dario,

On 11/12/2022 15:56, Dario Binacchi wrote:
> Hi Roger,
> 
> On Fri, Nov 25, 2022 at 1:38 PM Roger Quadros <rogerq at kernel.org> wrote:
>>
>> Hi Michael,
>>
>> On 08/11/2022 11:26, Michael Nazzareno Trimarchi wrote:
>>> Hi Roger
>>>
>>> On Fri, Nov 4, 2022 at 2:27 PM Roger Quadros <rogerq at kernel.org> wrote:
>>>>
>>>> Hi,
>>>>
>>>> On 11/10/2022 14:49, Roger Quadros wrote:
>>>>> Hi,
>>>>>
>>>>> This series adds driver model support for rawnand: omap_gpmc
>>>>> and omap_elm drivers.
>>>>>
>>>>> This will enable the driver to be used on K2/K3 platforms as well.
>>>>
>>>> Any comments on patches 5 and later? Thanks
>>>>
>>>
>>> We will try to close this week.
>>
>> Could you please give your comments on the last few patches. Thanks!
>>
>> cheers,
>> -roger
>>
>>>
>>> Michael
>>>
>>>>
>>>> cheers,
>>>> -roger
>>>>
>>>>>
>>>>> cheers,
>>>>> -roger
>>>>>
>>>>> Roger Quadros (14):
>>>>>   mtd: rawnand: omap_gpmc: Deprecate asm/arch/mem.h
>>>>>   mtd: rawnand: omap_gpmc: Enable build for K2/K3 platforms
>>>>>   mtd: rawnand: omap_gpmc: Fix build warning on 64-bit platforms
>>>>>   mtd: rawnand: omap_gpmc: Optimize NAND reads
>>>>>   mtd: rawnand: omap_gpmc: Fix BCH6/16 HW based correction
>>>>>   mtd: rawnand: nand_base: Allow base driver to be used in SPL without
>>>>>     nand_bbt
>>>>>   mtd: rawnand: nand_spl_loaders: Fix cast type build warning
>>>>>   mtd: rawnand: omap_gpmc: Reduce .bss usage
>>>>>   dt-bindings: mtd: Add ti,gpmc-nand DT binding documentation
>>>>>   mtd: rawnand: omap_gpmc: support u-boot driver model
>>>>>   mtd: rawnand: omap_gpmc: Add SPL NAND support
>>>>>   mtd: rawnand: omap_gpmc: Enable SYS_NAND_PAGE_COUNT for OMAP_GPMC
>>>>>   dt-bindings: mtd: Add ti,elm DT binding documentation
>>>>>   mtd: rawnand: omap_elm: u-boot driver model support
>>>>>
>>>>>  doc/device-tree-bindings/mtd/ti,elm.yaml      |  72 +++
>>>>>  .../mtd/ti,gpmc-nand.yaml                     | 129 +++++
>>>>>  drivers/mtd/nand/raw/Kconfig                  |  11 +-
>>>>>  drivers/mtd/nand/raw/Makefile                 |   2 +-
>>>>>  drivers/mtd/nand/raw/nand_base.c              |  18 +-
>>>>>  drivers/mtd/nand/raw/nand_spl_loaders.c       |   2 +-
>>>>>  drivers/mtd/nand/raw/omap_elm.c               |  33 +-
>>>>>  .../mtd => drivers/mtd/nand/raw}/omap_elm.h   |   6 +
>>>>>  drivers/mtd/nand/raw/omap_gpmc.c              | 500 +++++++++++++-----
>>>>>  9 files changed, 637 insertions(+), 136 deletions(-)
>>>>>  create mode 100644 doc/device-tree-bindings/mtd/ti,elm.yaml
>>>>>  create mode 100644 doc/device-tree-bindings/mtd/ti,gpmc-nand.yaml
>>>>>  rename {include/linux/mtd => drivers/mtd/nand/raw}/omap_elm.h (97%)
>>>>>
>>>
>>>
>>>
> 
> I tried to merge your whole series but after the second fix and the
> third time the CI/CD pipeline failed

Do you have the link to the failure?

> I thought it's better you fix the problems. So, I only accepted some
> of the first few patches in the series:
> 01/14 mtd: rawnand: omap_gpmc: Deprecate asm/arch/mem.h
> 02/14 mtd: rawnand: omap_gpmc: Enable build for K2/K3 platforms
> 03/14 mtd: rawnand: omap_gpmc: Fix build warning on 64-bit platforms
> 04/14 mtd: rawnand: omap_gpmc: Optimize NAND reads
> 07/14 mtd: rawnand: nand_spl_loaders: Fix cast type build warning
> 08/14 mtd: rawnand: omap_gpmc: Reduce .bss usage
> 
> For the others, please fix them to run the tests successfully.

No problem. I will try to fix and run them through the CI testing myself
before re-posting.

cheers,
-roger


More information about the U-Boot mailing list