[PATCH 3/3] cmd: pxe: use strdup to copy config

Tom Rini trini at konsulko.com
Tue Dec 13 14:34:34 CET 2022


On Tue, Dec 13, 2022 at 10:03:17AM +0100, Quentin Schulz wrote:
> Hi Tom,
> 
> On 12/12/22 22:34, Tom Rini wrote:
> > On Fri, Oct 28, 2022 at 11:01:20AM +0200, Patrick Delaunay wrote:
> > 
> > > Replace malloc and strcpy by strdup in
> > > function parse_label_kernel.
> > > 
> > > Signed-off-by: Patrick Delaunay <patrick.delaunay at foss.st.com>
> > > Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>
> > 
> > Applied to u-boot/next, thanks!
> > 
> 
> I believe this was a mistake?
> 
> This introduces a pretty bad regression as existing extlinux.conf won't boot
> anymore. Distros will need to have different extlinux depending on which
> U-Boot version is running on the system.
> 
> Was the merge done with this information in mind?

No, I was unware of that, sigh. I'll go push through a revert to next
shortly..

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20221213/5f97e52c/attachment.sig>


More information about the U-Boot mailing list