[PATCH 2/2] musb-new: omap2430: fix musb probing in gadget mode

Andreas Kemnade andreas at kemnade.info
Tue Dec 13 21:32:28 CET 2022


Hi,

just noticed I am doing two things in one patch.
better do it with just some patches

On Mon, 12 Dec 2022 14:00:57 -0500
Tom Rini <trini at konsulko.com> wrote:

> On Sat, Nov 26, 2022 at 11:30:10PM +0100, Andreas Kemnade wrote:
> 
> > Host mode structures were accessed but not initialized
first thing

->         struct usb_bus_priv *priv = dev_get_uclass_priv(dev);
which will be zero if not in host mode (and later priv->something is
accessed unconditional.

> > and gadget dm did not compile at all.
> > 
preparing things for DM_USB_GADGET should probably better
a separate patch. I will send an update hopefully soon.

> > Signed-off-by: Andreas Kemnade <andreas at kemnade.info>
> > ---
> >  drivers/usb/musb-new/omap2430.c | 42 ++++++++++++++++++++-------------
> >  1 file changed, 25 insertions(+), 17 deletions(-)  
> 
> This breaks omap3_beagle and omap3_evm.
> 

Regards,
Andreas


More information about the U-Boot mailing list