[PATCH v2 1/3] asm/arch-meson: add missing meson_sm_write_efuse signature

Simon Glass sjg at chromium.org
Wed Dec 14 05:39:46 CET 2022


Hi Alexey,

On Tue, 13 Dec 2022 at 10:32, Alexey Romanov <avromanov at sberdevices.ru> wrote:
>
> This function can be used by other modules.
>
> Signed-off-by: Alexey Romanov <avromanov at sberdevices.ru>
> ---
>  arch/arm/include/asm/arch-meson/sm.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/include/asm/arch-meson/sm.h b/arch/arm/include/asm/arch-meson/sm.h
> index f3ae46a6d6b..b68edf842e4 100644
> --- a/arch/arm/include/asm/arch-meson/sm.h
> +++ b/arch/arm/include/asm/arch-meson/sm.h
> @@ -8,6 +8,8 @@
>
>  ssize_t meson_sm_read_efuse(uintptr_t offset, void *buffer, size_t size);
>
> +ssize_t meson_sm_write_efuse(uintptr_t offset, void *buffer, size_t size);
> +
>  #define SM_SERIAL_SIZE 12
>
>  int meson_sm_get_serial(void *buffer, size_t size);
> --
> 2.25.1
>

Should add function comments.

Also, you might consider adding a uclass for this. It seems like an
important use case that is not handled right now.

Regards,
Simon


More information about the U-Boot mailing list