[PATCH] [RFC] cmd: pxe_utils: Limit fdtcontroladdr usage to non-fitImage

[Marek Vasut]

On 12/14/22 05:39, Simon Glass wrote:
> On Tue, 13 Dec 2022 at 12:46, Marek Vasut <marex at denx.de> wrote:
>>
>> Commit d5ba6188dfb ("cmd: pxe_utils: Check fdtcontroladdr in label_boot")
>> forces '$fdtcontroladdr' DT address as a third parameter of bootm command
>> even if the PXE transfer pulls in a fitImage which contains configuration
>> node with its own DT that is preferrable to be passed to Linux. Limit the
>> $fdtcontroladdr fallback utilization to non-fitImages, since it is highly
>> likely a fitImage would come with its own DT, while single-file images do
>> need a separate DT.
>>
>> Fixes: d5ba6188dfb ("cmd: pxe_utils: Check fdtcontroladdr in label_boot")
>> Signed-off-by: Marek Vasut <marex at denx.de>
>> ---
>> Cc: Peter Hoyes <Peter.Hoyes at arm.com>
>> Cc: Ramon Fried <rfried.dev at gmail.com>
>> Cc: Simon Glass <sjg at chromium.org>
>> ---
>>   boot/pxe_utils.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> I'd suggest adding an explicit comment in the code too, so it is
> easier to understand when this gets refactored later.

I sent a fixed version of this patch, can you add this RB to it too ?

Regarding comment in the code, there is already one massive comment 
explaining it just above, see the pxe_utils.c content in the sources.