[PATCH v2 1/3] asm/arch-meson: add missing meson_sm_write_efuse signature

[Neil Armstrong]

On 14/12/2022 05:39, Simon Glass wrote:
> Hi Alexey,
> 
> On Tue, 13 Dec 2022 at 10:32, Alexey Romanov <avromanov at sberdevices.ru> wrote:
>>
>> This function can be used by other modules.
>>
>> Signed-off-by: Alexey Romanov <avromanov at sberdevices.ru>
>> ---
>>   arch/arm/include/asm/arch-meson/sm.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/arch-meson/sm.h b/arch/arm/include/asm/arch-meson/sm.h
>> index f3ae46a6d6b..b68edf842e4 100644
>> --- a/arch/arm/include/asm/arch-meson/sm.h
>> +++ b/arch/arm/include/asm/arch-meson/sm.h
>> @@ -8,6 +8,8 @@
>>
>>   ssize_t meson_sm_read_efuse(uintptr_t offset, void *buffer, size_t size);
>>
>> +ssize_t meson_sm_write_efuse(uintptr_t offset, void *buffer, size_t size);
>> +
>>   #define SM_SERIAL_SIZE 12
>>
>>   int meson_sm_get_serial(void *buffer, size_t size);
>> --
>> 2.25.1
>>
> 
> Should add function comments.
> 
> Also, you might consider adding a uclass for this. It seems like an
> important use case that is not handled right now.

An NVMEM uclass would be a great addition, but for the scope of this
change it can be done later.

Neil

> 
> Regards,
> Simon
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#1378): https://groups.io/g/u-boot-amlogic/message/1378
> Mute This Topic: https://groups.io/mt/95651322/900740
> Group Owner: u-boot-amlogic+owner at groups.io
> Unsubscribe: https://groups.io/g/u-boot-amlogic/unsub [neil.armstrong at linaro.org]
> -=-=-=-=-=-=-=-=-=-=-=-
> 
>