Broken commit d433c74eecdce1e4952ef4e8c712a9289c0dfcc2

[Pali Rohár]

On Friday 05 August 2022 16:21:24 Pali Rohár wrote:
> Broken is also commit d433c74eecdce1e4952ef4e8c712a9289c0dfcc2. Seems
> that all kconfig migration changes done after that commit are broken.
> 
> I really do not have energy to investigate what and how was broken due
> to incorrect kconfig migration.
> 
> 
> I did simple test. Applied following change:
> 
> diff --git a/include/configs/p1_p2_rdb_pc.h b/include/configs/p1_p2_rdb_pc.h
> index a6523753d5ca..489f24df0ab1 100644
> --- a/include/configs/p1_p2_rdb_pc.h
> +++ b/include/configs/p1_p2_rdb_pc.h
> @@ -624,3 +624,7 @@ __stringify(__PCIE_RST_CMD)"\0"
>  "bootm $norbootaddr - $norfdtaddr"
>  
>  #endif /* __CONFIG_H */
> +
> +#ifdef CONFIG_SDCARD
> +#error
> +#endif
> 
> And then called:
> 
> make CROSS_COMPILE=powerpc-linux-gnuspe- P2020RDB-PC_defconfig u-boot.bin
> 
> And it failed, even when this defconfig file is not SD card builds.

Tom, that commit d433c74eecdce1e4952ef4e8c712a9289c0dfcc2 is yours.
Could you please look at it? Because it is a regressions which made P1
and P2 broken. Based on the past experience it really does not make
sense to wait for somebody who promised to do something as same
situation is just repeating.

Above diff is a simple check to verify if code conversion is correct or
not. If _before_ conversion CONFIG_SDCARD was not defined then also
_after_ conversion this macro must not be defined. Right?