[PATCH v2 2/2] eficonfig: avoid SetVariable between GetNextVariableName calls

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Mon Dec 19 22:18:04 CET 2022


On 12/19/22 02:33, Masahisa Kojima wrote:
> The current code calls efi_set_variable_int() to delete the
> invalid boot option between calls to efi_get_next_variable_name_int(),
> it may produce unpredictable results.
> 
> This commit moves removal of the invalid boot option outside
> of the efi_get_next_variable_name_int() calls.
> EFI_NOT_FOUND returned from efi_get_next_variable_name_int()
> indicates we retrieved all EFI variables, it should be treated
> as EFI_SUCEESS.
> 
> To address the checkpatch warning of too many leading tabs,
> combine two if statement into one.
> 
> Signed-off-by: Masahisa Kojima<masahisa.kojima at linaro.org>

Reviewed-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>



More information about the U-Boot mailing list