[RESEND RFC PATCH 1/2] Revert "video: Drop CONFIG_AM335X_LCD"

[Dario Binacchi]

Hi Simon,

On Mon, Dec 19, 2022 at 8:20 PM Simon Glass <sjg at chromium.org> wrote:
>
> Hi Dario,
>
> On Mon, 19 Dec 2022 at 04:35, Dario Binacchi
> <dario.binacchi at amarulasolutions.com> wrote:
> >
> > This reverts commit 82f7b869f5d7aad246a4621a18a5ad04475815ba.
> >
> > It also removed code with driver model support.
> > The commit [1], as described in its message, was also designed to make
> > it easy to remove pre-driver-model code in the near future.
> >
> > [1] 35ab1b6ef7f3a ("video: omap: split the legacy code from the DM code")
> > Signed-off-by: Dario Binacchi <dario.binacchi at amarulasolutions.com>
> > ---
> >
> >  arch/arm/mach-omap2/am33xx/clock_am33xx.c |   4 +
> >  board/bosch/guardian/board.c              |  70 ++++
> >  configs/am335x_guardian_defconfig         |   1 +
> >  drivers/video/Kconfig                     |   2 +
> >  drivers/video/Makefile                    |   1 +
> >  drivers/video/ti/Kconfig                  |   8 +
> >  drivers/video/ti/Makefile                 |  10 +
> >  drivers/video/ti/am335x-fb.c              | 318 ++++++++++++++++
> >  drivers/video/ti/am335x-fb.h              |  71 ++++
> >  drivers/video/ti/tilcdc-panel.c           | 172 +++++++++
> >  drivers/video/ti/tilcdc-panel.h           |  14 +
> >  drivers/video/ti/tilcdc.c                 | 426 ++++++++++++++++++++++
> >  drivers/video/ti/tilcdc.h                 |  38 ++
> >  13 files changed, 1135 insertions(+)
> >  create mode 100644 drivers/video/ti/Kconfig
> >  create mode 100644 drivers/video/ti/Makefile
> >  create mode 100644 drivers/video/ti/am335x-fb.c
> >  create mode 100644 drivers/video/ti/am335x-fb.h
> >  create mode 100644 drivers/video/ti/tilcdc-panel.c
> >  create mode 100644 drivers/video/ti/tilcdc-panel.h
> >  create mode 100644 drivers/video/ti/tilcdc.c
> >  create mode 100644 drivers/video/ti/tilcdc.h
>
> I'm sorry if I messed something up there. Can you add back just the DM
> code? We don't have lcd.h anymore.

Yes, you are right. I will submit v2, collapsing the two patches in
one only that
restores the DM code.
Furthermore, the two patches failed the compilation.

Thanks and regards,
Dario

>
> But if this is the way you want to do it:
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> Regards,
> Simon



-- 

Dario Binacchi

Embedded Linux Developer

dario.binacchi at amarulasolutions.com

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
info at amarulasolutions.com

www.amarulasolutions.com