[PATCH v1 1/1] makefile: add multi_dtb_fit dep

Frager, Neal neal.frager at amd.com
Thu Dec 22 07:16:18 CET 2022


Hi Simon,

>
> With certain gcc compilers, the u-boot.itb is built immediately after 
> dtb generation.  If CONFIG_MULTI_DTB_FIT is used, it is possible that 
> the fit-dtb.blob is not finished in time.
>
> This patch adds a necessary dependency to guarantee that the 
> fit-dtb.blob is built before attempting to build the u-boot.itb.
>
> Signed-off-by: Neal Frager <neal.frager at amd.com>
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index b96e2ffa15..682a5d94fd 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1425,6 +1425,7 @@ MKIMAGEFLAGS_u-boot.itb += -B 0x8  ifdef 
> U_BOOT_ITS
>  u-boot.itb: u-boot-nodtb.bin \
>                 $(if 
> $(CONFIG_OF_SEPARATE)$(CONFIG_OF_EMBED)$(CONFIG_SANDBOX),dts/dt.dtb) \
> +               $(if $(CONFIG_MULTI_DTB_FIT),$(FINAL_DTB_CONTAINER)) \
>                 $(U_BOOT_ITS) FORCE
>         $(call if_changed,mkfitimage)
>         $(BOARD_SIZE_CHECK)
> --
> 2.17.1
>

> Reviewed-by: Simon Glass <sjg at chromium.org>

> I wonder if we should try to get this moved to binman?

Thank you for the review!  Yes, the next step will be to move to binman.

Best regards,
Neal Frager
AMD


More information about the U-Boot mailing list