[PATCH v8 13/13] treewide: Disable USE_SPL_FIT_GENERATOR by default

Simon Glass sjg at chromium.org
Thu Dec 22 20:25:48 CET 2022


Hi Tom,

On Thu, 22 Dec 2022 at 10:57, Tom Rini <trini at konsulko.com> wrote:
>
> On Thu, Dec 22, 2022 at 10:41:17AM -0700, Simon Glass wrote:
> > Hi Tom,
> >
> > On Wed, 21 Dec 2022 at 16:11, Tom Rini <trini at konsulko.com> wrote:
> > >
> > > On Wed, Dec 21, 2022 at 04:07:26PM -0700, Simon Glass wrote:
> > > > This option is deprecated and only used by two boards. Enable it for just
> > > > those two boards, so others don't accidentally enable it.
> > > >
> > > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > >
> > > Wait, is this right? I thought when I had looked at this before the
> > > outliers were two imx boards, which I believe have now been converted.
> > > Is it really still in use on two xilinx platforms ?
> >
> > Yes I think the imx ones have gone away.
> >
> > For the penultimate commit:
> >
> > $ ./tools/moveconfig.py -f USE_SPL_FIT_GENERATOR
> > 2 matches
> > xilinx_zynqmp_virt avnet_ultrazedev_cc_v1_0_ultrazedev_som_v1_0
> >
> > So I believe this is still true.
>
> Enabled, yes, but is that subtool it sets actually used?
> xilinx_zynqmp_virt is in qemu CI even, so that can be quickly tested. I
> do wonder if the avnet board was enabling it because it was default and
> not using it.

When I try to disable it, I get:

make[1]: *** No rule to make target 'u-boot.itb', needed by
'.binman_stamp'.  Stop.

so I think it is needed by

Regards,
Simon


More information about the U-Boot mailing list