[PATCH V2 08/12] board: ti: j721s2: Add board_init and support for selecting DT based on EEPROM

[Tom Rini]

On Wed, Dec 21, 2022 at 07:22:15PM +0530, Sinthu Raja wrote:

> From: Sinthu Raja <sinthu.raja at ti.com>
> 
> Add the board_init_f API for SPL and run the platform-required SoC initialization.
> 
> Add the functionality for board name-based DTB selection from FIT within SPL. This
> will make it easier to utilise one defconfig for both the EVM and the SK.
> 
> Signed-off-by: Sinthu Raja <sinthu.raja at ti.com>
[snip]
> +#ifdef CONFIG_SPL_OF_LIST
> +void do_dt_magic(void)
> +{
> +        int ret, rescan, mmc_dev = -1;
> +        static struct mmc *mmc;
> +
> +        if (IS_ENABLED(CONFIG_TI_I2C_BOARD_DETECT))
> +                do_board_detect();

I think we should rework this slightly for clarity about mini-U-Boot vs
EVM and family support to be:

/* Support for the various EVM / SK families */
#if defined(CONFIG_SPL_OF_LIST) && defined(CONFIG_TI_I2C_BOARD_DETECT)
void do_dt_magic(void)
{
...

Instead. Or does that not work because of how we handle the R5 support
here? If we so, then please just add the comment.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20221223/4985a080/attachment.sig>