[PATCH] powerpc: dts: keymile: Deduplicate binman code
Pali Rohár
pali at kernel.org
Sat Dec 24 19:37:17 CET 2022
On Sunday 18 December 2022 11:04:11 Christophe Leroy wrote:
> Le 18/12/2022 à 11:59, Pali Rohár a écrit :
> > On Sunday 18 December 2022 09:29:23 Christophe Leroy wrote:
> >>>>>>>> - binman {
> >>>>>>>> - filename = "u-boot-with-dtb.bin";
> >>>>>>>> - skip-at-start = <CONFIG_SYS_TEXT_BASE>;
> >>>>>>>> - sort-by-offset;
> >>>>>>>> - pad-byte = <0xff>;
> >>>>>>>> - size = <CONFIG_SYS_MONITOR_LEN>;
> >>>>>>>> -
> >>>>>>>> - u-boot-with-ucode-ptr {
> >>>>>>>> - offset = <CONFIG_SYS_TEXT_BASE>;
> >>>>>>>> - optional-ucode;
> >>>>>>>> - };
> >>>>>>>> -
> >>>>>>>> - u-boot-dtb-with-ucode {
> >>>>>>>> - align = <256>;
> >>
> >> u-boot.dtsi has 'align = <4>' . Will it still work ?
> >
> > Yes, it must be <4> otherwise mpc85xx code does not boot. Other boards
> > use global u-boot.dtsi so they are already fixed. Just this one board
> > has copy of older (not fixed) content of u-boot.dtsi
> >
> > See commits where it was fixed for other boards:
> >
> > 7696b80ec5e9 powerpc: mpc85xx: Fix loading U-Boot proper from SD card in SPL
> > b898f6a6db76 powerpc: mpc85xx: Fix CONFIG_OF_SEPARATE support for NOR booting
> > e8c0e0064c8a powerpc: mpc85xx: Fix CONFIG_OF_SEPARATE support
> >
> > In separate thread is discussion about this issue:
> > https://lore.kernel.org/u-boot/20221217235913.w7ihsktbplbp2j7z@pali/
>
> Ok
>
> Reviewed-by: Christophe Leroy <christophe.leroy at csgroup.eu>
Ok, what else is needed for this patch?
More information about the U-Boot
mailing list