[PATCH v2 01/14] cmd: cpu: migrate cpu command to U_BOOT_CMD_WITH_SUBCMDS()

[Ovidiu Panait]

Hi Michal,

On 07.06.2022 11:33, Michal Simek wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
>
> út 31. 5. 2022 v 20:14 odesílatel Ovidiu Panait <ovpanait at gmail.com> napsal:
>
> Migrate cpu command to use U_BOOT_CMD_WITH_SUBCMDS() helper macro, to
> reduce duplicated code. This also fixes the cpu command on boards that
> enable CONFIG_NEEDS_MANUAL_RELOC.
>
> Signed-off-by: Ovidiu Panait <ovpanait at gmail.com>
> ---
> NOTE: this series depends on the following "events" patch:
> https://lore.kernel.org/u-boot/20220515184029.2169025-2-ovpanait@gmail.com/
[...]
>>  From my point of view this series looks good. I have sent v2 of mb
>> conversion rela and I prefer to apply this on the top.
>> There is actually one change needed bralid/brlid in one patch but I
>> have already did it and test it on the HW.
>> Will queue for the next u-boot version.

Thanks for the feedback! Could you also take in the following event 
patch that fixes the pointers after relocation (the cpu driver makes use 
of the events feature)? Without this, in my testing the event handlers 
are not called at all after relocation:

https://lore.kernel.org/u-boot/20220515184029.2169025-2-ovpanait@gmail.com/

It seems it is not currently applied to the 20220607-cache branch of 
u-boot-microblaze repo.


Thanks!

Ovidiu

>> Thanks,
>> Michal
>>
>> --
>> Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
>> w: www.monstr.eu p: +42-0-721842854
>> Maintainer of Linux kernel - Xilinx Microblaze
>> Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
>> U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs