[EXT] Re: [PATCH] crypto: fsl_hash: Remove unnecessary alignment check in caam_hash()

[ZHIZHIKIN Andrey]

Hello Gaurav,

> -----Original Message-----
> From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Gaurav Jain
> Sent: Wednesday, June 8, 2022 7:45 AM
> To: Fabio Estevam <festevam at gmail.com>; Heiko Thiery <heiko.thiery at gmail.com>
> Cc: Stefan Roese <sr at denx.de>; U-Boot-Denx <u-boot at lists.denx.de>;
> dullfire at yahoo.com; Rasmus Villemoes <rasmus.villemoes at prevas.dk>; Schrempf
> Frieder <frieder.schrempf at kontron.de>; ZHIZHIKIN Andrey <andrey.zhizhikin at leica-
> geosystems.com>; Horia Geanta <horia.geanta at nxp.com>; Thomas Schäfer
> <thomas.schaefer at kontron.com>; Ye Li <ye.li at nxp.com>; Peng Fan <peng.fan at nxp.com>
> Subject: RE: [EXT] Re: [PATCH] crypto: fsl_hash: Remove unnecessary alignment
> check in caam_hash()
> 
> Hi Fabio
> 
> > -----Original Message-----
> > From: Fabio Estevam <festevam at gmail.com>
> > Sent: Wednesday, June 8, 2022 4:20 AM
> > To: Heiko Thiery <heiko.thiery at gmail.com>
> > Cc: Stefan Roese <sr at denx.de>; U-Boot-Denx <u-boot at lists.denx.de>; Gaurav
> > Jain <gaurav.jain at nxp.com>; dullfire at yahoo.com; Rasmus Villemoes
> > <rasmus.villemoes at prevas.dk>; Schrempf Frieder
> > <frieder.schrempf at kontron.de>; ZHIZHIKIN Andrey <andrey.zhizhikin at leica-
> > geosystems.com>; Horia Geanta <horia.geanta at nxp.com>; Thomas Schäfer
> > <thomas.schaefer at kontron.com>; Ye Li <ye.li at nxp.com>; Peng Fan
> > <peng.fan at nxp.com>
> > Subject: [EXT] Re: [PATCH] crypto: fsl_hash: Remove unnecessary alignment
> > check in caam_hash()
> >
> > Caution: EXT Email
> >
> > On Tue, Jun 7, 2022 at 2:27 PM Fabio Estevam <festevam at gmail.com> wrote:
> > >
> > > Hi Heiko,
> > >
> > > On Tue, Jun 7, 2022 at 4:48 AM Heiko Thiery <heiko.thiery at gmail.com> wrote:
> > >
> > > >> Thomas Schäfer sees this behavior also on an imx8mn NXP evk board.
> > > >> Thus I added him to this thread.
> > >
> > > Thanks for the feedback.
> > >
> > > I managed to reproduce the problem on an imx8mm-evk board.
> > >
> > > On top of tree U-Boot I added:
> > >
> > > --- a/configs/imx8mm_evk_defconfig
> > > +++ b/configs/imx8mm_evk_defconfig
> > > @@ -87,3 +87,4 @@ CONFIG_SYSRESET_PSCI=y
> > CONFIG_SYSRESET_WATCHDOG=y
> > > CONFIG_DM_THERMAL=y  CONFIG_IMX_WATCHDOG=y
> > > +CONFIG_IMX_HAB=y
> > >
> > > Then I try to load the fitImage and the sha256 calculation via CAAM fails:
> > >
> > > U-Boot SPL 2022.07-rc3-00093-g7d3acf08ec60-dirty (Jun 07 2022 -
> > > 14:20:02 -0300)
> > > SEC0:  RNG instantiated
> > > Normal Boot
> > > WDT:   Started watchdog at 30280000 with servicing (60s timeout)
> > > Trying to boot from MMC1
> > > hab fuse not enabled
> > >
> > > Authenticate image from DDR location 0x401fcdc0...
> > > bad magic magic=0x0 length=0x00 version=0x0 bad length magic=0x0
> > > length=0x00 version=0x0 bad version magic=0x0 length=0x00 version=0x0
> > > Error: Invalid IVT structure
> > > NOTICE:  BL31: v2.4(release):lf-5.15.5-1.0.0-10-gcb51a0faa4b6
> >
> > The problem seems to be related to the TF-A version.
> >
> > If I use the older imx_5.4.47_2.2.0 TF-A then the sha256 calculation via CAAM
> > does not fail.
> 
> I think you are right.  Patch submitted in TFA for not releasing JR0 to non-
> secure which is causing this issue.
> https://git.trustedfirmware.org/TF-A/trusted-firmware-
> a.git/commit/?h=refs/heads/integration&id=77850c96f23bcdc76ecb0ecd27a982c00fde5d9
> d
> 

I believe that Fabio used NXP TF-A for booting, while you're referring to upstream
TF-A commit.

Coming back to our discussion that we had with CAAM support series, which JRs are
now used for which purposes? Does upstream TF-A (so as NXP TF-A) reserves JR0 for
HAB operations, hence JR1 is required in U-Boot for crypto operations?

Is it possible that you provide a clear picture of JR reservations in all
combinations of SPL -> TF-A (upstream or NXP) -> U-Boot?

> I will share a patch for switching to JR1 in uboot.
> 
> Regards
> Gaurav Jain
> >
> > Regards,
> >
> > Fabio Estevam

Regards,
Andrey