[PATCH 17/18] tpl: Ensure all TPL symbols in Kconfig have some TPL dependency
Tom Rini
trini at konsulko.com
Wed Jun 8 14:24:39 CEST 2022
Tighten up symbol dependencies in a number of places. Ensure that a TPL
specific option has at least a direct dependency on TPL. In places
where it's clear that we depend on something more specific, use that
dependency instead.
Reported-by: Pali Rohár <pali at kernel.org>
Signed-off-by: Tom Rini <trini at konsulko.com>
---
arch/x86/Kconfig | 1 +
boot/Kconfig | 2 +-
common/Kconfig | 3 ++-
drivers/core/Kconfig | 2 +-
drivers/power/acpi_pmc/Kconfig | 1 +
drivers/ram/Kconfig | 2 +-
lib/Kconfig | 3 ++-
7 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 6b3765c997da..7e86c6a0cd0a 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -957,6 +957,7 @@ config SPL_ACPI_GPE
config TPL_ACPI_GPE
bool "Support ACPI general-purpose events in TPL"
+ depends on TPL
help
Enable a driver for ACPI GPEs to allow peripherals to send interrupts
via ACPI to the OS. In U-Boot this is only used when U-Boot itself
diff --git a/boot/Kconfig b/boot/Kconfig
index 1aee2de8f302..63dacc0d14f4 100644
--- a/boot/Kconfig
+++ b/boot/Kconfig
@@ -622,7 +622,7 @@ config SPL_BOOTSTAGE
config TPL_BOOTSTAGE
bool "Boot timing and reported in TPL"
- depends on BOOTSTAGE
+ depends on BOOTSTAGE && TPL
help
Enable recording of boot time in SPL. To make this visible to U-Boot
proper, enable BOOTSTAGE_STASH as well. This will stash the timing
diff --git a/common/Kconfig b/common/Kconfig
index 079670ddd12f..ac88d9bf9eab 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -88,6 +88,7 @@ config SPL_LOGLEVEL
config TPL_LOGLEVEL
int
+ depends on TPL
default LOGLEVEL
config VPL_LOGLEVEL
@@ -409,7 +410,7 @@ endif
config TPL_LOG
bool "Enable logging support in TPL"
- depends on LOG
+ depends on LOG && TPL
help
This enables support for logging of status and debug messages. These
can be displayed on the console, recorded in a memory buffer, or
diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
index 9b9a7148a1a4..d3fe1d4093d9 100644
--- a/drivers/core/Kconfig
+++ b/drivers/core/Kconfig
@@ -224,7 +224,7 @@ config SPL_SYSCON
config TPL_SYSCON
bool "Support system controllers in TPL"
- depends on SPL_REGMAP
+ depends on TPL_REGMAP
help
Many SoCs have a number of system controllers which are dealt with
as a group by a single driver. Some common functionality is provided
diff --git a/drivers/power/acpi_pmc/Kconfig b/drivers/power/acpi_pmc/Kconfig
index 8b712abc41e9..629acb071427 100644
--- a/drivers/power/acpi_pmc/Kconfig
+++ b/drivers/power/acpi_pmc/Kconfig
@@ -18,6 +18,7 @@ config SPL_ACPI_PMC
config TPL_ACPI_PMC
bool "Power Manager (x86 PMC) support in TPL"
+ depends on TPL
default y if ACPI_PMC
help
Enable support for an x86-style power-management controller which
diff --git a/drivers/ram/Kconfig b/drivers/ram/Kconfig
index 709c916a2a11..96e04a98ce17 100644
--- a/drivers/ram/Kconfig
+++ b/drivers/ram/Kconfig
@@ -19,7 +19,7 @@ config SPL_RAM
config TPL_RAM
bool "Enable RAM support in TPL"
- depends on RAM
+ depends on RAM && TPL
help
The RAM subsystem adds a small amount of overhead to the image.
If this is acceptable and you have a need to use RAM drivers in
diff --git a/lib/Kconfig b/lib/Kconfig
index 40db6d5ba922..fef71606766e 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -249,6 +249,7 @@ config SPL_TINY_MEMSET
config TPL_TINY_MEMSET
bool "Use a very small memset() in TPL"
+ depends on TPL
help
The faster memset() is the arch-specific one (if available) enabled
by CONFIG_USE_ARCH_MEMSET. If that is not enabled, we can still get
@@ -777,7 +778,7 @@ config TPL_OF_LIBFDT
config TPL_OF_LIBFDT_ASSUME_MASK
hex "Mask of conditions to assume for libfdt"
- depends on TPL_OF_LIBFDT || FIT
+ depends on TPL_OF_LIBFDT || (FIT && TPL)
default 0xff
help
Use this to change the assumptions made by libfdt in TPL about the
--
2.25.1
More information about the U-Boot
mailing list