[PATCH] crypto: fsl_hash: Remove unnecessary alignment check in caam_hash()

[ZHIZHIKIN Andrey]

Hello Fabio,

> -----Original Message-----
> From: Fabio Estevam <festevam at gmail.com>
> Sent: Wednesday, June 8, 2022 2:14 PM
> To: ZHIZHIKIN Andrey <andrey.zhizhikin at leica-geosystems.com>
> Cc: Heiko Thiery <heiko.thiery at gmail.com>; Stefan Roese <sr at denx.de>; U-Boot-Denx
> <u-boot at lists.denx.de>; Gaurav Jain <gaurav.jain at nxp.com>; dullfire at yahoo.com;
> Rasmus Villemoes <rasmus.villemoes at prevas.dk>; Schrempf Frieder
> <frieder.schrempf at kontron.de>; Horia Geanta Neag <horia.geanta at nxp.com>; Thomas
> Schaefer <thomas.schaefer at kontron.com>; Ye Li <ye.li at nxp.com>; Peng Fan
> <peng.fan at nxp.com>
> Subject: Re: [PATCH] crypto: fsl_hash: Remove unnecessary alignment check in
> caam_hash()
> 
> 
> Hi Andrey,
> 
> On Wed, Jun 8, 2022 at 4:46 AM ZHIZHIKIN Andrey
> <andrey.zhizhikin at leica-geosystems.com> wrote:
> 
> > > The problem seems to be related to the TF-A version.
> > >
> > > If I use the older imx_5.4.47_2.2.0 TF-A then the sha256 calculation
> > > via CAAM does not fail.
> >
> > I just tried the imx8mp_evk and with CONFIG_IMX_HAB=y the board
> > does not pass the SPL.
> >
> > I used the upstream TF-A for my build, without HAB support
> > enabled the board boots:
> > ----
> > U-Boot SPL 2022.07-rc4-00003-g9eca6cc66a (Jun 08 2022 - 08:21:41 +0200)
> > SEC0:  RNG instantiated
> > Normal Boot
> > WDT:   Started watchdog at 30280000 with servicing (60s timeout)
> > Trying to boot from BOOTROM
> > image offset 0x8000, pagesize 0x200, ivt offset 0x0
> > NOTICE:  BL31: v2.7(release):v2.7.0-17-g65a5e1c04-dirty
> > NOTICE:  BL31: Built : 06:19:26, Jun  8 2022
> >
> >
> > U-Boot 2022.07-rc4-00003-g9eca6cc66a (Jun 08 2022 - 08:21:41 +0200)
> >
> > CPU:   Freescale i.MX8MP[8] rev1.0 at 1200 MHz
> > Reset cause: POR
> > Model: NXP i.MX8MPlus EVK board
> > DRAM:  6 GiB
> > Core:  176 devices, 22 uclasses, devicetree: separate
> > WDT:   Started watchdog at 30280000 with servicing (60s timeout)
> > MMC:   FSL_SDHC: 1, FSL_SDHC: 2
> > Loading Environment from MMC... *** Warning - bad CRC, using default
> environment
> >
> > In:    serial at 30890000
> > Out:   serial at 30890000
> > Err:   serial at 30890000
> > SEC0:  RNG instantiated
> > Net:   eth0: ethernet at 30be0000, eth1: ethernet at 30bf0000 [PRIME]
> > Hit any key to stop autoboot:  0
> > u-boot=>
> > ----
> >
> > When HAB in enabled, the only thing that can be observed in the
> > console is:
> > ----
> > U-Boot SPL 2022.07-rc4-00003-g9eca6cc66a-dirty (Jun 08 2022 - 09:40:52 +0200)
> 
> My understanding, at least for the i.MX8MM case, is that mainline TF-A
> does not support HAB,
> so the NXP TF-A should be used if HAB support is required.
> 
> Please check:
> https://lists.trustedfirmware.org/archives/list/tf-a@lists.trustedfirmware.org/message/5UYYI4CNLQ5OWWHU466JBK6I5QIQ2VRS/
> 

Thanks for the hint!

That would be understandable, but I would at least be expecting
to have some error messages. But I do not get any - the board just
does not pass SPL at all, as like SEC0 hangs during RNG instantiation
(my rough speculations here).

> Does the board boot with IMX_HAB=y with NXP TF-A?

Nope, unfortunately also not. Once HAB config is enabled on the
i.MX8MP - the board does not pass the SPL, even with NXP TF-A.

> 
> Regards,
> 
> Fabio Estevam

-- andrey