[PATCH] board: ti: am335x: eth_cpsw should depend on CONFIG_NET

Andrew Davis afd at ti.com
Tue Jun 14 16:07:15 CEST 2022


On 6/14/22 3:44 AM, Corentin LABBE wrote:
> The origin of this patch is the breaking of am335x-hs boot
> due to commit e41651fffda7 ("dm: Support parent devices with of-platdata")
> HS boards have less SRAM for SPL and so this commit increased memory usage beyond am335x limit.
> This commit added 10 driver binding pass and am335x boot only if one pass is done.
> SPL try to do more than one pass due to eth_cpsw failing.
> Since HS SPL does not need network (and NET is already disabled in config),
> the easiest fix is to "remove" eth_cpsw from SPL by testing if NET is enabled.
> 
> Signed-off-by: Corentin LABBE <clabbe at baylibre.com>
> ---


If no one was using this data I wonder if the compiler could have removed
it with LTO enabled.. Something to think on.

Acked-by: Andrew Davis <afd at ti.com>


>   board/ti/am335x/board.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/ti/am335x/board.c b/board/ti/am335x/board.c
> index 7c0545892c..2cb5b1cb3f 100644
> --- a/board/ti/am335x/board.c
> +++ b/board/ti/am335x/board.c
> @@ -902,7 +902,7 @@ int board_late_init(void)
>   #endif
>   
>   /* CPSW plat */
> -#if !CONFIG_IS_ENABLED(OF_CONTROL)
> +#if CONFIG_IS_ENABLED(NET) && !CONFIG_IS_ENABLED(OF_CONTROL)
>   struct cpsw_slave_data slave_data[] = {
>   	{
>   		.slave_reg_ofs  = CPSW_SLAVE0_OFFSET,


More information about the U-Boot mailing list