[PATCH v3] crypto/fsl: fsl_rsa: Fix dcache issue in the driver

[Stefano Babic]

Hi Gaurav,

thanks for fix, I will put into u-boot-imx and trigger a new CI.

Stefano

On 15.06.22 14:34, Gaurav Jain wrote:
> From: Ye Li <ye.li at nxp.com>
> 
> issue:
> CAAM fails with key error when perform Modular Exponentiation
> using PKHA Block in CAAM
> 
> Fix:
> add flush and invalidate dcache for keys, signature
> and output decrypted data processed by CAAM.
> 
> Fixes: 34276478f7 (DM: crypto/fsl - Add Freescale rsa DM driver)
> Signed-off-by: Ye Li <ye.li at nxp.com>
> Reviewed-by: Gaurav Jain <gaurav.jain at nxp.com>
> Acked-by: Peng Fan <peng.fan at nxp.com>
> ---
>   drivers/crypto/fsl/fsl_rsa.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/crypto/fsl/fsl_rsa.c b/drivers/crypto/fsl/fsl_rsa.c
> index 897ee855ea..335b7fe25a 100644
> --- a/drivers/crypto/fsl/fsl_rsa.c
> +++ b/drivers/crypto/fsl/fsl_rsa.c
> @@ -6,6 +6,7 @@
>   
>   #include <config.h>
>   #include <common.h>
> +#include <cpu_func.h>
>   #include <dm.h>
>   #include <log.h>
>   #include <asm/types.h>
> @@ -36,12 +37,21 @@ int fsl_mod_exp(struct udevice *dev, const uint8_t *sig, uint32_t sig_len,
>   
>   	inline_cnstr_jobdesc_pkha_rsaexp(desc, &pkin, out, sig_len);
>   
> +	flush_dcache_range((ulong)sig, (ulong)sig + sig_len);
> +	flush_dcache_range((ulong)prop->modulus, (ulong)(prop->modulus) + keylen);
> +	flush_dcache_range((ulong)prop->public_exponent,
> +			   (ulong)(prop->public_exponent) + prop->exp_len);
> +	flush_dcache_range((ulong)desc, (ulong)desc + (sizeof(uint32_t) * MAX_CAAM_DESCSIZE));
> +	flush_dcache_range((ulong)out, (ulong)out + sig_len);
> +
>   	ret = run_descriptor_jr(desc);
>   	if (ret) {
>   		debug("%s: RSA failed to verify: %d\n", __func__, ret);
>   		return -EFAULT;
>   	}
>   
> +	invalidate_dcache_range((ulong)out, (ulong)out + sig_len);
> +
>   	return 0;
>   }
>