[PATCH 1/1] efi_loader: initialize console size late

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Fri Jun 17 06:59:29 CEST 2022



On 6/17/22 00:50, Tom Rini wrote:
> On Tue, Jun 14, 2022 at 08:02:03AM +0200, Heinrich Schuchardt wrote:
> 
>> From: Heinrich Schuchardt <xypron.glpk at gmx.de>
>>
>> If CONFIG_VIDEO_DM=n we query the display size from the serial console.
>> Especially when using a remote console the response can be so late that
>> it interferes with autoboot.
>>
>> Only query the console size when running an EFI binary.
>>
>> Add debug output showing the determined console size.
>>
>> Reported-by: Fabio Estevam <festevam at gmail.com>
>> Fixes: a9bf024b2933 ("efi_loader: disk: a helper function to create efi_disk objects from udevice")
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>> Tested-by: Fabio Estevam <festevam at denx.de>
>> Tested-by: Heiko Thiery <heiko.thiery at gmail.com>
> 
> This causes: https://source.denx.de/u-boot/u-boot/-/jobs/450891#L229
> for all instances of sandbox running that test.
> 

This is a only a bug to the test environment:

test/py/u_boot_console_base.py:110:
self.prompt_compiled = re.compile('^' + re.escape(self.prompt), 
re.MULTILINE)

There must not be any byte before the prompt on the line for the test 
environment to recognize it as a prompt.

I will look into the problem.

Best regards

Heinrich


More information about the U-Boot mailing list