[PATCH v3 2/2] pmic: pca9450: Add regulator driver

[Marek Vasut]

On 6/19/22 18:01, Heiko Thiery wrote:

[...]

>>> +static int pca9450_set_value(struct udevice *dev, int uvolt)
>>> +{
>>> +       struct pca9450_plat *plat = dev_get_plat(dev);
>>> +       unsigned int sel;
>>> +       int i, found = 0;
>>> +
>>> +       /*
>>> +        * An under/overshooting may occur if voltage is changed for other
>>> +        * regulators but buck 1,2,3 or 4 when regulator is enabled. Prevent
>>> +        * change to protect the HW
>>> +        */
>>
>> To be able to configure the pmic/regulators during startup by the dm
>> (regulators_enable_boot_on) I think we have to
>> remove the checks for the permit. Otherwise the automatic configuration on hand
>> of the dtb settings won't work.
>>
> 
> I tried to find the root of the comment above. Since the driver is
> probably based
> on the ROHM BD71837 and this comment can be found there as well, the
> limitation probably comes from this type.
> 
> Can this be?

Most likely this comment is bogus copy-paste from the ROHM PMIC driver.

[...]