[PATCH v2 01/15] firmware: zynqmp: Check if rx channel dev pointer is valid

Michal Simek monstr at monstr.eu
Fri Jun 24 14:42:01 CEST 2022



On 6/20/22 18:36, Stefan Herbrechtsmeier wrote:
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
> 
> Check if rx channel dev pointer is valid and not if the address of the
> pointer is valid.
> 
> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
> ---
> 
> (no changes since v1)
> 
>   drivers/firmware/firmware-zynqmp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/firmware-zynqmp.c b/drivers/firmware/firmware-zynqmp.c
> index 0f0d2b07c0..341d7cf135 100644
> --- a/drivers/firmware/firmware-zynqmp.c
> +++ b/drivers/firmware/firmware-zynqmp.c
> @@ -92,7 +92,7 @@ static int ipi_req(const u32 *req, size_t req_len, u32 *res, size_t res_maxlen)
>   	    res_maxlen > PMUFW_PAYLOAD_ARG_CNT)
>   		return -EINVAL;
>   
> -	if (!(zynqmp_power.tx_chan.dev) || !(&zynqmp_power.rx_chan.dev))
> +	if (!(zynqmp_power.tx_chan.dev) || !(zynqmp_power.rx_chan.dev))
>   		return -EINVAL;
>   
>   	debug("%s, Sending IPI message with ID: 0x%0x\n", __func__, req[0]);

Applied.
M
-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs



More information about the U-Boot mailing list