[PATCH 20/20] Convert CONFIG_SYS_BOOTM_LEN to Kconfig

Soeren Moch smoch at web.de
Sun Jun 26 00:01:23 CEST 2022


>>> diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig
>>> index 892d7c60d283..f0ecfd049d65 100644
>>> --- a/configs/tbs2910_defconfig
>>> +++ b/configs/tbs2910_defconfig
>>> @@ -35,6 +35,7 @@ CONFIG_CMD_BOOTZ=y
>>>    # CONFIG_BOOTM_PLAN9 is not set
>>>    # CONFIG_BOOTM_RTEMS is not set
>>>    # CONFIG_BOOTM_VXWORKS is not set
>>> +CONFIG_SYS_BOOTM_LEN=0x1000000
>> For tbs2910 there is another value set here - not the old default, not
>> the new one. Why?
>> This looks like a carefully chosen value, but very likely it is not.
>>
>> Probably also this value is fine for this board, but for me it makes no
>> sense to set a board specific value here.
> I don't follow you, sorry.  Since tbs2910 isn't X86 or PPC or ARM64,
> it's using the current value instead.  Before this patch
> include/configs/tbs2910.h includes include/configs/mx6_common.h which
> sets it to 0x1000000.
OK, I missed that part in the long patch, my bad.

As I wrote, all possible values are probably good for this board.
I just would prefer to use some default value (as before), since there
is no special requirement for this board in particular. To keep the
old value in this conversion of course makes sense.
> Which means I probably could put a || ARCH_MX6 in
> the Kconfig entry and drop out another 84 files (3 MX6 platforms set
> 0x4000000 instead today).
>
That would make it more obvious that the old default is used for
these boards. But if you prefer the board specific defconfig
setting, that of course is also a valid solution.

Regards,
Soeren


More information about the U-Boot mailing list