[PATCH RESEND 3/5] config/ast2600: Disable hash hardware accel

[Neal Liu]

> Hello Neal
> 
> On 6/27/22 10:55, Neal Liu wrote:
> >> Reviewed-by: Chia-Wei Wang <chiawei_wang at aspeedtech.com>
> >>
> >> The QEMU emulation issue is under investigation by Steven.
> >> The CRC32 and MD5 SW support will be added before we re-enabling HW
> >> crypto drivers.
> >>
> >> Chiawei
> >>
> >>> From: joel.stan at gmail.com <joel.stan at gmail.com> On Behalf Of Joel
> >>> Stanley
> >>> Sent: Monday, June 27, 2022 3:58 PM
> >>>
> >>> The HACE driver lacks support for all the hash types, causing boot
> >>> to fail with the default FIT configuration which uses CRC32.
> >>>
> >>> Additionally the Qemu model or the u-boot driver is unable to
> >>> correctly compute the SHA256 hash used in a FIT.
> >>>
> >>> Disable HACE by default while the above issues are worked out to
> >>> enable boot testing in Qemu.
> >
> > I don't think this is the right way to do it.
> >
> > First, it's fine that drivers can only support some algos. There is no rules that
> it must support CRC32.
> 
> 
> For CRC32, I understand that the driver should be able to fallback to the SW
> implementation.  It is not the case today. With some debug in
> aspeed_hace_finish() :
> 
>    U-Boot SPL 2022.07-rc5-dirty (Jun 27 2022 - 09:01:28 +0200)
>    already initialized, Trying to boot from RAM
>    ## Checking hash(es) for config conf-1 ... OK
>    ## Checking hash(es) for Image firmware-1 ... crc32Unsupported hash
> algorithm 'crc32' error!
>    Unsupported hash algorithm for 'hash-1' hash node in 'firmware-1' image
> node
> 
> The above is not related to QEMU.
> 
> Thanks,
> 
> C.

The fallback need to be fixed of course. We would send a patch to fix this.
Thanks

> 
> 
> 
> > Second, if Qemu test is failure, it should fix the Qemu HACE driver or disable
> it in Qemu, not in common defconfig in u-boot.
> > This will affect lots of people who use mainline for developments and
> productions.
> > Thanks,
> >
> > -Neal
> >