[PATCH] gpio: renesas: Simplify .request/.rfree callbacks

Pali Rohár pali at kernel.org
Tue Nov 1 23:57:32 CET 2022


On Sunday 09 October 2022 14:34:55 Pali Rohár wrote:
> On Friday 02 September 2022 21:56:07 Pali Rohár wrote:
> > On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote:
> > > On 02.08.22 12:06, Pali Rohár wrote:
> > > > Remove identify wrapper functions.
> > > > 
> > > > Signed-off-by: Pali Rohár <pali at kernel.org>
> > > 
> > > Reviewed-by: Stefan Roese <sr at denx.de>
> > 
> > Any more comments? Or could it be merged?
> 
> PING after another month?

PING?

> > > Thanks,
> > > Stefan
> > > 
> > > > ---
> > > >   drivers/gpio/gpio-rcar.c | 15 ++-------------
> > > >   1 file changed, 2 insertions(+), 13 deletions(-)
> > > > 
> > > > diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> > > > index 138801850d3e..ba00bb459679 100644
> > > > --- a/drivers/gpio/gpio-rcar.c
> > > > +++ b/drivers/gpio/gpio-rcar.c
> > > > @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct udevice *dev, unsigned offset)
> > > >   		return GPIOF_INPUT;
> > > >   }
> > > > -static int rcar_gpio_request(struct udevice *dev, unsigned offset,
> > > > -			     const char *label)
> > > > -{
> > > > -	return pinctrl_gpio_request(dev, offset, label);
> > > > -}
> > > > -
> > > > -static int rcar_gpio_free(struct udevice *dev, unsigned offset)
> > > > -{
> > > > -	return pinctrl_gpio_free(dev, offset);
> > > > -}
> > > > -
> > > >   static const struct dm_gpio_ops rcar_gpio_ops = {
> > > > -	.request		= rcar_gpio_request,
> > > > -	.rfree			= rcar_gpio_free,
> > > > +	.request		= pinctrl_gpio_request,
> > > > +	.rfree			= pinctrl_gpio_free,
> > > >   	.direction_input	= rcar_gpio_direction_input,
> > > >   	.direction_output	= rcar_gpio_direction_output,
> > > >   	.get_value		= rcar_gpio_get_value,
> > > 
> > > Viele Grüße,
> > > Stefan Roese
> > > 
> > > -- 
> > > DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > > Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de


More information about the U-Boot mailing list