[RFC PATCH v5 00/24] Modernize U-Boot shell

[Holger Brunck]

Hi Francis,

> I was able to have the CI passes but I had to not use
> CONFIG_HUSH_2021_PARSER for two boards:
> 1. u-boot.img file size for the rcar3_ulcb, when built with
> CONFIG_HUSH_PARSER_2021, exceeds the 1MB file limit of 890 bytes.
> It should be possible to reduce the image size by not compiling some hush
> features (e.g. loop) for this particular board.
> 2. The keymile board family is the only set of boards to call get_local_var(),
> set_local_var() and unset_local_var().
> Sadly, these functions are static in this contribution.
> I could have change all of them to introduce code like this:
> *_local_var(/*...*/)
> {
>         if (gd->flags & GD_FLG_HUSH_OLD_PARSER)
>                 return *_local_var_old(/*...*/);
>         if (gd->flags & GD_FLG_HUSH_2021_PARSER)
>                 return *_local_var_2021(/*...*/); } But this would have mean renaming
> all old hush functions calls and I did not want to change the old hush particularly
> to avoid breaking things.
> Instead, I change the keymile board to use environment variable instead of local
> ones.
> I think this particularities can be addressed in future works.
> 

you can for your rework simply replace the calls for our boards to use environment
variables as you proposed in your initial patch.  I will put it on my list and we have
to find a different solution for us in the future.

Best regards
Holger