[PATCH v2 1/1] usb: storage: continue probe on "Invalid device"

[Marek Vasut]

On 11/4/22 08:35, Janne Grunau wrote:
> On 2022-11-03 23:23:52 +0100, Marek Vasut wrote:
>> On 11/3/22 22:36, Janne Grunau wrote:
>>> On 2022-09-28 04:20:52 -0600, Simon Glass wrote:
>>>> +Marek Vasut
>>>> +Tom Rini
>>>>
>>>> On Sun, 25 Sept 2022 at 23:07, Janne Grunau <j at jannau.net> wrote:
>>>>>
>>>>> On 2022-08-10 21:54:22 +0200, Janne Grunau wrote:
>>>>>> Fixes a crash during probing of sd card readers without medium present.
>>>>>>
>>>>>> Link: https://github.com/AsahiLinux/linux/issues/44
>>>>>> Link: https://lists.denx.de/pipermail/u-boot/2022-July/489717.html
>>>>>> Signed-off-by: Janne Grunau <j at jannau.net>
>>>>>> ---
>>>>>> Changes since v1:
>>>>>>    - changed unconditiona return to "continue" as proposed by AKASHI Takahiro
>>>>>>
>>>>>>    common/usb_storage.c | 1 +
>>>>>>    1 file changed, 1 insertion(+)
>>>>>>
>>>>>> diff --git a/common/usb_storage.c b/common/usb_storage.c
>>>>>> index eaa31374ef73..f9204552a683 100644
>>>>>> --- a/common/usb_storage.c
>>>>>> +++ b/common/usb_storage.c
>>>>>> @@ -239,6 +239,7 @@ static int usb_stor_probe_device(struct usb_device *udev)
>>>>>>                         ret = device_unbind(dev);
>>>>>>                         if (ret)
>>>>>>                                 return ret;
>>>>>> +                     continue;
>>>>>>                 }
>>>>>>
>>>>>>                 ret = blk_probe_or_unbind(dev);
>>>>>
>>>>> ping. Is there anything holding up merging this fix?
>>>
>>> ping2
>>>
>>> This fixes a 100% reproducible crash when an USB storage device with
>>> "medium not ready" is connected.
>>
>> Can you please CC me next time when submitting these kinds of USB fixes ?
> 
> sure, the cc list was the get_maintainers.pl output.

Ah, the MAINTAINERS entry is wrong, fix is out, thanks.

>> Also, can you tell which device this is ?
> 
> I don't think the device matters but I'm seeing this problem with
> 
> Bus 002 Device 005: ID 0bda:0326 Realtek Semiconductor Corp. Card reader
> Device Descriptor:
>    bLength                18
>    bDescriptorType         1
>    bcdUSB               3.00
>    bDeviceClass            0 bDeviceSubClass         0 bDeviceProtocol
> 0 bMaxPacketSize0         9
>    idVendor           0x0bda Realtek Semiconductor Corp.
>    idProduct          0x0326 Card reader

I'll see if I can get one of these for testing, thanks.