[PATCH v3 8/9] global: Do not default to faking missing binaries for buildman

Heinrich Schuchardt xypron.glpk at gmx.de
Sun Nov 6 00:32:55 CET 2022


On 11/6/22 00:04, Simon Glass wrote:
> From: Tom Rini <trini at konsulko.com>
>
> While it is possible and documented on how to re-run buildman to replace
> faked required binary files after the fact, this behavior ends up being
> more confusing than helpful in practice. Switch to requiring
> BINMAN_ALLOW_MISSING=1 to be passed on the 'make' line to enable this
> behavior.

Please, document all relevant environment variables for binman in
doc/develop/package/binman.rst. (This could be a follow up patch to the
series.)

Best regards

Heinrich

>
> Cc: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
> Cc: Simon Glass <sjg at chromium.org>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> (no changes since v1)
>
>   Makefile | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 3f900855c22..5bbb6dc3a71 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1333,8 +1333,8 @@ cmd_binman = $(srctree)/tools/binman/binman $(if $(BINMAN_DEBUG),-D) \
>   		$(foreach f,$(BINMAN_TOOLPATHS),--toolpath $(f)) \
>                   --toolpath $(objtree)/tools \
>   		$(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \
> -		build -u -d u-boot.dtb -O . -m --allow-missing \
> -		--fake-ext-blobs \
> +		build -u -d u-boot.dtb -O . -m \
> +		$(if $(BINMAN_ALLOW_MISSING),--allow-missing --fake-ext-blobs) \
>   		-I . -I $(srctree) -I $(srctree)/board/$(BOARDDIR) \
>   		-I arch/$(ARCH)/dts -a of-list=$(CONFIG_OF_LIST) \
>   		$(foreach f,$(BINMAN_INDIRS),-I $(f)) \



More information about the U-Boot mailing list