[PATCH 3/4] fwu: gpt: implement read_mdata and write_mdata callbacks

[Jassi Brar]

On Mon, Nov 7, 2022 at 11:23 AM Etienne Carriere
<etienne.carriere at linaro.org> wrote:
>
> On Fri, 4 Nov 2022 at 03:43, <jassisinghbrar at gmail.com> wrote:
> >
> > From: Jassi Brar <jaswinder.singh at linaro.org>
> >
> > Moving towards using common code for meta-data management,
> > implement the read/write mdata hooks.
> >
> > Signed-off-by: Jassi Brar <jaswinder.singh at linaro.org>
> > ---
> >  drivers/fwu-mdata/gpt_blk.c | 36 ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 36 insertions(+)
> >
> > diff --git a/drivers/fwu-mdata/gpt_blk.c b/drivers/fwu-mdata/gpt_blk.c
> > index d706e3d4e4..7fda041302 100644
> > --- a/drivers/fwu-mdata/gpt_blk.c
> > +++ b/drivers/fwu-mdata/gpt_blk.c
> > @@ -272,7 +272,43 @@ static int fwu_mdata_gpt_blk_probe(struct udevice *dev)
> >         return 0;
> >  }
> >
> > +static int fwu_gpt_read_mdata(struct udevice *dev, struct fwu_mdata *mdata,
> > +                                                bool primary)
> > +{
> > +       struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev);
> > +       struct blk_desc *desc = dev_get_uclass_plat(priv->blk_dev);
> > +       int ret;
> > +
> > +       ret = gpt_get_mdata_partitions(desc);
> > +       if (ret < 0) {
> > +               log_debug("Error getting the FWU metadata partitions\n");
> > +               return -ENOENT;
>
> Not returning ret value?
>
It is unchanged from original behavior.

> > +       }
> > +
> > +       return gpt_read_write_mdata(desc, mdata, MDATA_READ,
> > +                                       primary ? g_mdata_part[0] : g_mdata_part[1]);
>
> Fix indentation.
>
>
> > +}
> > +
> > +static int fwu_gpt_write_mdata(struct udevice *dev, struct fwu_mdata *mdata,
> > +                                                bool primary)
> > +{
> > +       struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev);
> > +       struct blk_desc *desc = dev_get_uclass_plat(priv->blk_dev);
> > +       int ret;
> > +
> > +       ret = gpt_get_mdata_partitions(desc);
> > +       if (ret < 0) {
> > +               log_debug("Error getting the FWU metadata partitions\n");
> > +               return -ENOENT;
> > +       }
> > +
> > +       return gpt_read_write_mdata(desc, mdata, MDATA_WRITE,
> > +                                       primary ? g_mdata_part[0] : g_mdata_part[1]);
>
> Dito
>
OK.

thanks.