[PATCH] fdt: Fix bounds check in devfdt_get_addr_index

Simon Glass sjg at chromium.org
Tue Nov 8 00:35:47 CET 2022


Hi Samuel,

On Mon, 31 Oct 2022 at 13:27, Simon Glass <sjg at chromium.org> wrote:
>
> On Sun, 30 Oct 2022 at 21:41, Samuel Holland <samuel at sholland.org> wrote:
> >
> > reg must contain enough cells for the entire next address/size pair
> > after skipping `index` pairs. The previous code allows an out-of-bounds
> > read when na + ns > 1.
> >
> > Fixes: 69b41388ba45 ("dm: core: Add a new api to get indexed device address")
> > Signed-off-by: Samuel Holland <samuel at sholland.org>
> > ---
> >
> >  drivers/core/fdtaddr.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Somehow this break PPC in CI:

https://source.denx.de/u-boot/custodians/u-boot-dm/-/jobs/524776

Can you please take a look?

Regards,
SImon


More information about the U-Boot mailing list