[PATCH v5 2/2] serial: mxc: have putc use the TXFIFO

[SCHNEIDER Johannes]

Hi Fabio,


gave it another round, and discussed it with Grygorii - he pointed out that it would be better to do the "fifo empty" or even better "byte sent" checks in "our" code instead of adding more complexity to the serial_mxc for handling a buffer/TXFIFO to be properly flushed prior to each of the multiple calls to set_baudrate during startup between spl and uboot;
i tried a couple of approaches which would add checks to "pending" to either a new "puts"-method, or "set_bgr" with partial success - the problem remains that long printfs during board_init - which happens before the serial device is actually fully initialized - get cut of near the end... anyway: added complexity -> !KISS

so i'd say go for the revert; which reduces use of the fifo back to just the first byte


sorry for the trouble
Johannes


________________________________________
From: Fabio Estevam <festevam at gmail.com>
Sent: Monday, November 7, 2022 22:17
To: SCHNEIDER Johannes; TERTYCHNYI Grygorii
Cc: Pali Rohár; Fabio Estevam; Tim Harvey; u-boot at lists.denx.de; peng.fan at oss.nxp.com; sbabic at denx.de; trini; GEO-CHHER-bsp-development; Peng Fan
Subject: Re: [PATCH v5 2/2] serial: mxc: have putc use the TXFIFO

This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.


Hi Johannes and Grygorii,

On Thu, Nov 3, 2022 at 8:14 AM Fabio Estevam <festevam at gmail.com> wrote:

> There is a typo here: it should be mxc_serial_putc() instead.
>
> No, it does not fix the issue.
>
> Not sure why you mentioned imx6. The issue can be reproduced on imx8mm as well.

Do you plan to submit a patch fixing the regression?

Thanks