[PATCH v6 10/10] arm_ffa: efi: corstone1000: enable MM communication

[Abdellatif El Khlifi]

On Mon, Oct 24, 2022 at 03:13:08PM +0300, Ilias Apalodimas wrote:
> On Thu, Oct 13, 2022 at 11:38:57AM +0100, Abdellatif El Khlifi wrote:
> > turn on EFI MM communication
> > 
> > On corstone1000 platform MM communication between u-boot
> > and the secure world (Optee) is done using the FF-A bus.
> > 
> > Signed-off-by: Abdellatif El Khlifi <abdellatif.elkhlifi at arm.com>
> > Cc: Tom Rini <trini at konsulko.com>
> > Cc: Simon Glass <sjg at chromium.org>
> > Cc: Ilias Apalodimas <ilias.apalodimas at linaro.org>
> > Cc: Jens Wiklander <jens.wiklander at linaro.org>
> > 
> > ---
> > 
> > Changelog:
> > ===============
> > 
> > v6:
> > 
> > * corstone-1000: enable optee driver
> > * corstone-1000: remove CONFIG_ARM_FFA_EFI_RUNTIME_MODE from the defconfig
> > 
> > v4:
> > 
> > * corstone-1000: turn on EFI MM communication
> > 
> >  configs/corstone1000_defconfig | 4 ++++
> >  include/configs/corstone1000.h | 9 +++++++++
> >  2 files changed, 13 insertions(+)
> > 
> > diff --git a/configs/corstone1000_defconfig b/configs/corstone1000_defconfig
> > index ed2e0fe70a..4c9ed9fb71 100644
> > --- a/configs/corstone1000_defconfig
> > +++ b/configs/corstone1000_defconfig
> > @@ -52,3 +52,7 @@ CONFIG_DM_SERIAL=y
> >  CONFIG_USB=y
> >  CONFIG_USB_ISP1760=y
> >  CONFIG_ERRNO_STR=y
> > +CONFIG_EFI_MM_COMM_TEE=y
> > +CONFIG_TEE=y
> > +CONFIG_OPTEE=y
> > +CONFIG_ARM_FFA_TRANSPORT=y
> > diff --git a/include/configs/corstone1000.h b/include/configs/corstone1000.h
> > index 8e0230c135..997d0bebaf 100644
> > --- a/include/configs/corstone1000.h
> > +++ b/include/configs/corstone1000.h
> > @@ -14,6 +14,15 @@
> >  
> >  #include <linux/sizes.h>
> >  
> > +#define FFA_SHARED_MM_BUFFER_SIZE	SZ_4K /* 4 KB */
> > +
> > +/*
> > + * shared buffer physical address used for communication between
> > + * u-boot and the MM SP
> > + */
> > +#define FFA_SHARED_MM_BUFFER_ADDR	(0x023F8000)
> > +#define FFA_SHARED_MM_BUFFER_OFFSET	(0)
> 
> The rest of the declarations on this file don't have () so please remove
> them.  Also is FFA_SHARED_MM_BUFFER_ADDR used anywhere that would justify UL
> in the suffix?

Done in v7.

> 
> Thanks
> /Ilias
> > +
> >  #define V2M_BASE		0x80000000
> >  
> >  #define CONFIG_PL011_CLOCK	50000000
> > -- 
> > 2.17.1
> >