[PATCH] eficonfig: fix missing variable initialization

Ilias Apalodimas ilias.apalodimas at linaro.org
Mon Nov 14 12:15:30 CET 2022


On Mon, 14 Nov 2022 at 11:59, Masahisa Kojima
<masahisa.kojima at linaro.org> wrote:
>
> The 'ret' variable must be initialized before use
> in eficonfig_delete_invalid_boot_option().
>
> Fixes: c416f1c0bc ("bootmenu: add removable media entries")
> Addresses-Coverity: 376207 ("Uninitialized variables")
> Signed-off-by: Masahisa Kojima <masahisa.kojima at linaro.org>
> ---
>  cmd/eficonfig.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c
> index 2595dd9563..0a768d8013 100644
> --- a/cmd/eficonfig.c
> +++ b/cmd/eficonfig.c
> @@ -2280,10 +2280,10 @@ efi_status_t eficonfig_delete_invalid_boot_option(struct eficonfig_media_boot_op
>  {
>         u32 i, j;
>         efi_uintn_t size;
> -       efi_status_t ret;
>         void *load_option;
>         struct efi_load_option lo;
>         u16 varname[] = u"Boot####";
> +       efi_status_t ret = EFI_SUCCESS;
>
>         for (i = 0; i <= 0xFFFF; i++) {
>                 efi_uintn_t tmp;
> --
> 2.17.1
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>


More information about the U-Boot mailing list