[PATCH 1/1] doc: fix documentation of enum gd_flags

Rasmus Villemoes rasmus.villemoes at prevas.dk
Tue Nov 15 13:10:13 CET 2022


On 14/11/2022 10.25, Heinrich Schuchardt wrote:
> Correct GD_FLG_CYCLIC_RUNNING documentation to match Sphinx style.
> 
> Fixes: d7de5ef62935 ("cyclic: use a flag in gd->flags for recursion protection")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>

Ack, obviously.

But now that I look in global_data.h again, it struck me that
GD_FLG_WDT_READY has become write-only since c2fd0ca1a822. That is, it
is set in initr_watchdog but nothing ever test for it.

So we should probably remove that bit (and that line in initr_watchdog),
and then fill the vacant spot with GD_FLG_CYCLIC_RUNNING.

Rasmus



More information about the U-Boot mailing list