[PATCH 0/3] cmd: pxe: support INITRD and FDT selection with FIT

[Quentin Schulz]

Hi Patrick,

Thanks for looking at it.

On 10/28/22 11:01, Patrick Delaunay wrote:
> 
> Since the commit d5ba6188dfbf ("cmd: pxe_utils: Check fdtcontroladdr
> in label_boot") the FDT or the FDTDIR label is required in extlinux.conf
> and the fallback done by bootm command when only the device tree is present
> in this command parameters is no more performed when FIT is used for
> kernel.
> 
> The next file "extlinux.conf" no more selects the device tree in FIT
> but use the pxe fallback with the device tree of U-Boot.
> 
> menu title Select the boot mode
> DEFAULT test
> LABEL test
>          KERNEL /fitImage
> 
> This serie restores the possibility to use a FIT in extlinux.conf
> by using FDT label with the same string.
> 
> menu title Select the boot mode
> DEFAULT test
> LABEL test
>          KERNEL /fitImage
>          FDT /fitImage
> 
> even when a specific FIT config is used:
> 
> menu title Select the boot mode
> DEFAULT test
> LABEL test
>          KERNEL /fitImage#config
>          FDT /fitImage#config
> 
> The last commit of the series is only a minor improvement.
> 

I tested this on my Puma RK3399 and it does work again, thanks.

However, I'm not sure this is what we should go for?

My worry is the following:
What happens for old releases (pre-v2022.04) where KERNEL worked just 
fine without the FDT to load the fdt from the fitimage conf specified in 
KERNEL field? Would we now need to keep an extlinux.conf for pre-2022.04 
releases where FDT wouldn't be set and one for 2023.01 and later where 
FDT would be mentioned? That does not seem like a good thing for distros.

I unfortunately cannot answer the question myself without spending 
significant effort patching v2022.01 to get it to work on our Puma 
module. Does anyone have access to a board to quickly check an 
extlinux.conf with KERNEL and FDT set to /fitImage on a v2022.01 release?

Is there really no other way than adding this new requirement? (Nothing 
against it if it does not break older releases with the "new" 
extlinux.conf though).

Cheers,
Quentin