[PATCH] Subject: [patch]SPI: GD SPI: Add Gigadevice SPI NOR part numbers

[Vlim]

Hi, Michal,

Regarding the following item,

>   drivers/mtd/spi/spi-nor-ids.c             | 137 +++++++++++++++-------
>   3 files changed, 94 insertions(+), 45 deletions(-)
>
> diff --git a/configs/xilinx_zynqmp_mini_qspi_defconfig b/configs/xilinx_zynqmp_mini_qspi_defconfig
> index c6401c2a54..75014117f1 100644
> --- a/configs/xilinx_zynqmp_mini_qspi_defconfig
> +++ b/configs/xilinx_zynqmp_mini_qspi_defconfig
> @@ -78,3 +78,4 @@ CONFIG_ZYNQMP_GQSPI=y
>   CONFIG_PANIC_HANG=y
>   # CONFIG_GZIP is not set
>   # CONFIG_LMB is not set
> +CONFIG_SPI_FLASH_GIGADEVICE=y

This is likely just appended and doesn't reflect Kconfig layout.
Run make xilinx_zynqmp_mini_qspi_defconfig; make savedefconfig; cp defconfig
configs/xilinx_zynqmp_mini_qspi_defconfig


I have the following script for uboot compilation, should I add the following lines to my script?
make savedefconfig;
cp defconfig configs/xilinx_zynqmp_mini_qspi_defconfig

This is my script,
source /tools/Xilinx/Vivado/2022.2/settings64.sh
export CROSS_COMPILE=aarch64-linux-gnu-
export ARCH=aarch64
make distclean
make xilinx_zynqmp_mini_qspi_defconfig
make -j8 DEVICE_TREE=zynqmp-mini-qspi-single
cp u-boot.elf zynqmp_qspi_x4_single.bin

Regards,

Victor

________________________________
From: Michal Simek <michal.simek at amd.com>
Sent: Monday, November 21, 2022 02:34
To: Victor lim <victorswlim at gmail.com>; u-boot at lists.denx.de <u-boot at lists.denx.de>; michal.simek at xilinx.com <michal.simek at xilinx.com>; jagan at amarulasolutions.com <jagan at amarulasolutions.com>; vigneshr at ti.com <vigneshr at ti.com>
Cc: vikhyat.goyal at amd.com <vikhyat.goyal at amd.com>; ashok.reddy.soma at amd.com <ashok.reddy.soma at amd.com>; Vlim <vlim at gigadevice.com>
Subject: Re: [PATCH] Subject: [patch]SPI: GD SPI: Add Gigadevice SPI NOR part numbers

[You don't often get email from michal.simek at amd.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

此为外部邮件，谨防钓鱼邮件，请注意邮件是否涉及敏感信息

This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information


On 11/17/22 01:56, Victor lim wrote:
> added gigadevice in the defconfig file and ID in the ids.c file
>
> Signed-off-by: Victor Lim <vlim at gigadevice.com>
> ---
>   configs/xilinx_zynqmp_mini_qspi_defconfig |   1 +
>   configs/zynq_cse_qspi_defconfig           |   1 +

This should be done in separate patch.

>   drivers/mtd/spi/spi-nor-ids.c             | 137 +++++++++++++++-------
>   3 files changed, 94 insertions(+), 45 deletions(-)
>
> diff --git a/configs/xilinx_zynqmp_mini_qspi_defconfig b/configs/xilinx_zynqmp_mini_qspi_defconfig
> index c6401c2a54..75014117f1 100644
> --- a/configs/xilinx_zynqmp_mini_qspi_defconfig
> +++ b/configs/xilinx_zynqmp_mini_qspi_defconfig
> @@ -78,3 +78,4 @@ CONFIG_ZYNQMP_GQSPI=y
>   CONFIG_PANIC_HANG=y
>   # CONFIG_GZIP is not set
>   # CONFIG_LMB is not set
> +CONFIG_SPI_FLASH_GIGADEVICE=y

This is likely just appended and doesn't reflect Kconfig layout.
Run make xilinx_zynqmp_mini_qspi_defconfig; make savedefconfig; cp defconfig
configs/xilinx_zynqmp_mini_qspi_defconfig

> diff --git a/configs/zynq_cse_qspi_defconfig b/configs/zynq_cse_qspi_defconfig
> index 60f0d7cac4..cd245906ab 100644
> --- a/configs/zynq_cse_qspi_defconfig
> +++ b/configs/zynq_cse_qspi_defconfig
> @@ -76,3 +76,4 @@ CONFIG_ARM_DCC=y
>   CONFIG_ZYNQ_QSPI=y
>   # CONFIG_GZIP is not set
>   # CONFIG_LMB is not set
> +CONFIG_SPI_FLASH_GIGADEVICE=y

ditto. I am also fine with enabling these memories for zynqmp_virt/zynq_virt and
versal_virt and versal_net_virt platforms.

Hard to guess what you have changed below. But if you want to change style it is
one patch. If you want to add new devices it is another patch.

Thanks,
Michal