[PATCH 37/38] post: Migrate to Kconfig

[Simon Glass]

Hi Tom,

On Mon, 21 Nov 2022 at 15:57, Tom Rini <trini at konsulko.com> wrote:
>
> On Mon, Nov 21, 2022 at 03:51:10PM -0700, Simon Glass wrote:
> > On Sat, 19 Nov 2022 at 16:53, Tom Rini <trini at konsulko.com> wrote:
> > >
> > > We move the existing CONFIG_POST_* functionality over to CFG_POST and
> > > then introduce CONFIG_POST to Kconfig.
> > >
> > > Signed-off-by: Tom Rini <trini at konsulko.com>
> > > ---
> > >  arch/powerpc/cpu/mpc85xx/cpu.c                |  2 +-
> > >  configs/P2041RDB_NAND_defconfig               |  1 +
> > >  configs/P2041RDB_SDCARD_defconfig             |  1 +
> > >  configs/P2041RDB_SPIFLASH_defconfig           |  1 +
> > >  configs/P2041RDB_defconfig                    |  1 +
> > >  configs/kmcent2_defconfig                     |  1 +
> > >  configs/kmcoge5ne_defconfig                   |  1 +
> > >  configs/pg_wcom_expu1_defconfig               |  1 +
> > >  configs/pg_wcom_expu1_update_defconfig        |  1 +
> > >  configs/pg_wcom_seli8_defconfig               |  1 +
> > >  configs/pg_wcom_seli8_update_defconfig        |  1 +
> > >  doc/README.POST                               |  6 +-
> > >  doc/README.fsl-ddr                            |  2 +-
> > >  drivers/serial/serial-uclass.c                |  2 +-
> > >  drivers/serial/serial.c                       |  2 +-
> > >  include/configs/P2041RDB.h                    |  2 +-
> > >  include/configs/km/pg-wcom-ls102xa.h          |  4 +-
> > >  include/configs/kmcent2.h                     |  2 +-
> > >  include/configs/kmcoge5ne.h                   |  4 +-
> > >  include/post.h                                |  4 +-
> > >  include/serial.h                              |  4 +-
> > >  post/cpu/mpc83xx/ecc.c                        |  2 +-
> > >  post/drivers/flash.c                          |  2 +-
> > >  post/drivers/i2c.c                            |  4 +-
> > >  post/drivers/memory.c                         |  4 +-
> > >  post/drivers/rtc.c                            |  4 +-
> > >  post/lib_powerpc/andi.c                       |  2 +-
> > >  post/lib_powerpc/asm.S                        |  2 +-
> > >  post/lib_powerpc/b.c                          |  2 +-
> > >  post/lib_powerpc/cmp.c                        |  2 +-
> > >  post/lib_powerpc/cmpi.c                       |  2 +-
> > >  post/lib_powerpc/complex.c                    |  2 +-
> > >  post/lib_powerpc/cpu.c                        |  4 +-
> > >  post/lib_powerpc/cr.c                         |  2 +-
> > >  post/lib_powerpc/fpu/20001122-1.c             |  4 +-
> > >  post/lib_powerpc/fpu/20010114-2.c             |  4 +-
> > >  post/lib_powerpc/fpu/20010226-1.c             |  4 +-
> > >  post/lib_powerpc/fpu/980619-1.c               |  4 +-
> > >  post/lib_powerpc/fpu/acc1.c                   |  4 +-
> > >  post/lib_powerpc/fpu/compare-fp-1.c           |  4 +-
> > >  post/lib_powerpc/fpu/fpu.c                    |  4 +-
> > >  post/lib_powerpc/fpu/mul-subnormal-single-1.c |  4 +-
> > >  post/lib_powerpc/load.c                       |  2 +-
> > >  post/lib_powerpc/multi.c                      |  2 +-
> > >  post/lib_powerpc/rlwimi.c                     |  2 +-
> > >  post/lib_powerpc/rlwinm.c                     |  2 +-
> > >  post/lib_powerpc/rlwnm.c                      |  2 +-
> > >  post/lib_powerpc/srawi.c                      |  2 +-
> > >  post/lib_powerpc/store.c                      |  2 +-
> > >  post/lib_powerpc/string.c                     |  2 +-
> > >  post/lib_powerpc/three.c                      |  2 +-
> > >  post/lib_powerpc/threei.c                     |  2 +-
> > >  post/lib_powerpc/threex.c                     |  2 +-
> > >  post/lib_powerpc/two.c                        |  2 +-
> > >  post/lib_powerpc/twox.c                       |  2 +-
> > >  post/post.c                                   |  4 +-
> > >  post/tests.c                                  | 68 +++++++++----------
> > >  test/Kconfig                                  |  5 ++
> > >  58 files changed, 114 insertions(+), 99 deletions(-)
> > >
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> >
> > but please see below
> >
> > > diff --git a/test/Kconfig b/test/Kconfig
> > > index a6b463e4d06c..9f4641ae6bc5 100644
> > > --- a/test/Kconfig
> > > +++ b/test/Kconfig
> > > @@ -1,3 +1,8 @@
> > > +config POST
> > > +       bool "Power On Self Test support"
> > > +       help
> > > +         See doc/README.POST for more details
> >
> > Shouldn't this be in post/Kconfig ?
>
> It's non-trivial enough content that it really should be migrated to
> doc/post/ and then expanded upon a bit further.
>
> > We use test/ for unit / functional tests.
>
> Yes, but post pre-dates all of that, keep in mind. It's also still in
> active use (enabled on some semi-recent layerscape platforms for
> example). This is an area that could use some attention and renovation,
> yes, but the whole point of this and the huge follow-up are to get the
> migrate to Kconfig part done already.

OK, good to get all this over the line!!

Regards,
Simon