[PATCH v8 07/10] arm_ffa: introduce Sandbox test cases for UCLASS_FFA

Simon Glass sjg at chromium.org
Wed Nov 23 03:09:19 CET 2022


Hi Abdellatif,

On Tue, 22 Nov 2022 at 06:18, Abdellatif El Khlifi
<abdellatif.elkhlifi at arm.com> wrote:
>
> Add functional test cases for the FF-A core driver
>
> These tests rely on the FF-A Sandbox driver which helps in
>  inspecting the FF-A core driver.
>
> Signed-off-by: Abdellatif El Khlifi <abdellatif.elkhlifi at arm.com>
> Cc: Tom Rini <trini at konsulko.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Ilias Apalodimas <ilias.apalodimas at linaro.org>
> Cc: Jens Wiklander <jens.wiklander at linaro.org>
>
> ---
>
> Changelog:
> ===============
>
> v8:
>
>   * update partition_info_get() second argument to be an SP count
>   * pass NULL device pointer to the FF-A bus discovery and operations
>
> v7: set the tests to use 64-bit direct messaging
>
> v4: align sandbox tests with the new FF-A driver interfaces
>  and new way of error handling
>
> v1: introduce sandbox tests
>
> MAINTAINERS      |   1 +
>  test/dm/Makefile |   2 +
>  test/dm/ffa.c    | 392 +++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 395 insertions(+)
>  create mode 100644 test/dm/ffa.c

This looks OK to me, but for sorting out how devices are bound /
probed and how to call into a uclass.

Also, just return 0, not CMD_RET_SUCCESS. This isn't actually a
command :-) Even if it were, 0 is better.

Regards,
Simon


More information about the U-Boot mailing list