[PATCH v4 1/1] u-boot-initial-env: rework make target

[Tom Rini]

On Wed, Nov 23, 2022 at 07:22:52PM +0100, Pali Rohár wrote:
> On Wednesday 23 November 2022 13:18:40 Tom Rini wrote:
> > On Tue, Nov 08, 2022 at 09:52:22AM +0100, Max Krummenacher wrote:
> > 
> > > From: Max Krummenacher <max.krummenacher at toradex.com>
> > > 
> > > With LTO enabled the U-Boot initial environment is no longer stored
> > > in an easy accessible section in env/common.o. I.e. the section name
> > > changes from build to build, its content maybe compressed and it is
> > > annotated with additional data.
> > > 
> > > Drop trying to read the initial env with elf tools from the compiler
> > > specific object file in favour of adding and using a host tool with
> > > the only functionality of printing the initial env to stdout.
> > > 
> > > See also:
> > > https://lore.kernel.org/all/927b122e-1f62-e790-f5ca-30bae4332c77@foss.st.com/
> > > 
> > > Signed-off-by: Max Krummenacher <max.krummenacher at toradex.com>
> > > Acked-by: Pali Rohár <pali at kernel.org>
> > 
> > Alright, so 'make tools-only_defconfig tools-only' now fails to build
> > because we're missing the dependencies to make sure that we have
> > generated/environment.h available.
> > https://source.denx.de/u-boot/u-boot/-/jobs/532186
> 
> We cannot generate generated/environment.h in tools-only mode without
> real board because environment is always board dependent.
> 
> Therefore that new env tool has to be compiled only when doing full real
> board build, not just tools-only build.
> 
> So I would suggest to extend Makefile put that new tool under some "if"
> to exclude compilation in tools-only mode.

Note that "tools-only_defconfig" builds a functional sandbox U-Boot, so
it's probably easier to get the dependencies right in the Makefile
logic, rather than special case them.  Especially since we're now
building this for everyone it's now a race to make sure we did generate
that file? I don't have a strong preference on how this is solved,
however.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20221123/6fb16293/attachment.sig>