[PATCH 1/7] mtd: replace name of 'rfree' field with 'free' in struct mtd_ooblayout_ops to better match it's description

Frieder Schrempf frieder.schrempf at kontron.de
Thu Nov 24 16:09:17 CET 2022


On 07.10.22 13:58, Fabio Estevam wrote:
> On Fri, Oct 7, 2022 at 8:34 AM Michael Nazzareno Trimarchi
> <michael at amarulasolutions.com> wrote:
> 
>> About this change, there was a commit from Simon 8d38a8459b0
>> that was renamed. You ask basically to revert it
> 
> Correct, what about fixing it like this?
> 
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index ff635bd716..09f5269887 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -122,7 +122,7 @@ struct mtd_oob_region {
>   * @ecc: function returning an ECC region in the OOB area.
>   *      Should return -ERANGE if %section exceeds the total number of
>   *      ECC sections.
> - * @free: function returning a free region in the OOB area.
> + * @rfree: function returning a free region in the OOB area.
>   *       Should return -ERANGE if %section exceeds the total number of
>   *       free sections.
>   */

But do we really want to stay out of sync with the Linux kernel code? Is
the reasoning behind Simon's change in 8d38a8459b0 still valid today?


More information about the U-Boot mailing list