[PATCH] gpio: renesas: Simplify .request/.rfree callbacks

[Marek Vasut]

On 11/2/22 09:58, Stefan Roese wrote:
> Hi Pali,

Hello Stefan,

> added Marek to Cc

Thank you.

> On 01.11.22 23:57, Pali Rohár wrote:
>> On Sunday 09 October 2022 14:34:55 Pali Rohár wrote:
>>> On Friday 02 September 2022 21:56:07 Pali Rohár wrote:
>>>> On Wednesday 03 August 2022 08:48:39 Stefan Roese wrote:
>>>>> On 02.08.22 12:06, Pali Rohár wrote:
>>>>>> Remove identify wrapper functions.
>>>>>>
>>>>>> Signed-off-by: Pali Rohár <pali at kernel.org>
>>>>>
>>>>> Reviewed-by: Stefan Roese <sr at denx.de>
>>>>
>>>> Any more comments? Or could it be merged?
>>>
>>> PING after another month?
>>
>> PING?
> 
> Marek, could you please take a look? This patch is delegated to you
> in patchworks:
> 
> http://patchwork.ozlabs.org/project/uboot/patch/20220802100655.17965-1-pali@kernel.org/

It would be better if the patch author added me to CC, that could've 
prevented those frustrated pings with no response.

>>>>>> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
>>>>>> index 138801850d3e..ba00bb459679 100644
>>>>>> --- a/drivers/gpio/gpio-rcar.c
>>>>>> +++ b/drivers/gpio/gpio-rcar.c
>>>>>> @@ -130,20 +130,9 @@ static int rcar_gpio_get_function(struct 
>>>>>> udevice *dev, unsigned offset)
>>>>>>            return GPIOF_INPUT;
>>>>>>    }
>>>>>> -static int rcar_gpio_request(struct udevice *dev, unsigned offset,
>>>>>> -                 const char *label)
>>>>>> -{
>>>>>> -    return pinctrl_gpio_request(dev, offset, label);
>>>>>> -}
>>>>>> -
>>>>>> -static int rcar_gpio_free(struct udevice *dev, unsigned offset)
>>>>>> -{
>>>>>> -    return pinctrl_gpio_free(dev, offset);
>>>>>> -}
>>>>>> -
>>>>>>    static const struct dm_gpio_ops rcar_gpio_ops = {
>>>>>> -    .request        = rcar_gpio_request,
>>>>>> -    .rfree            = rcar_gpio_free,
>>>>>> +    .request        = pinctrl_gpio_request,
>>>>>> +    .rfree            = pinctrl_gpio_free,
>>>>>>        .direction_input    = rcar_gpio_direction_input,
>>>>>>        .direction_output    = rcar_gpio_direction_output,
>>>>>>        .get_value        = rcar_gpio_get_value,

The patch is obviously OK,

Reviewed-by: Marek Vasut <marex at denx.de>