[PATCH] usb: gadget: dfu: Fix the unchecked length field

Marek Vasut marex at denx.de
Tue Nov 29 22:53:23 CET 2022


On 11/29/22 20:49, Sultan Khan wrote:
> While I haven't yet gotten around to trying DFU with this patch applied, my
> guess as to the issue would be the checks of the form "if (ctrl->
> bRequestType == USB_DIR_OUT)" or "if (ctrl->bRequestType == USB_DIR_IN)".
> The bRequestType field contains many flag bits other than the direction
> bit. The checks should just check that the USB_DIR_IN bit (0x80) is set or
> not set, rather than checking if the entire ctrl->bRequestType field equals
> some value.
> 
> Sultan

I'm looking forward to a proper fix, thanks !


More information about the U-Boot mailing list