[PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

[Tim Harvey]

On Mon, Oct 3, 2022 at 10:13 AM Fabio Estevam <festevam at gmail.com> wrote:
>
> Hi Tim,
>
> On Wed, Sep 28, 2022 at 4:37 PM Tim Harvey <tharvey at gateworks.com> wrote:
>
> > diff --git a/configs/gwventana_gw5904_defconfig b/configs/gwventana_gw5904_defconfig
> > index 8c6baf0ae5e2..33b57c5a1c5d 100644
> > --- a/configs/gwventana_gw5904_defconfig
> > +++ b/configs/gwventana_gw5904_defconfig
> > @@ -111,11 +111,11 @@ CONFIG_SUPPORT_EMMC_BOOT=y
> >  CONFIG_FSL_USDHC=y
> >  CONFIG_MTD=y
> >  CONFIG_PHYLIB=y
> > -CONFIG_MV88E61XX_SWITCH=y
> > -CONFIG_MV88E61XX_CPU_PORT=5
> > -CONFIG_MV88E61XX_PHY_PORTS=0xf
> > -CONFIG_MV88E61XX_FIXED_PORTS=0x0
> > +CONFIG_MV88E61XX=y
>
> There is a typo here:
>
> This one should be CONFIG_MV88E6XXX instead.

Ooops - thanks for pointing that out. I have another patch on top to
merge two defconfigs that fixed that typo introduced with the v4
series that changed MV88E61XX to MV88E6XXX.

>
> After fixing this and passing CONFIG_NET_RANDOM_ETHADDR=y to my custom
> board defconfig:
>
>  ethernet      0  [ + ]   fecmxc                |   |   `-- ethernet at 30be0000
>  bootdev       2  [   ]   eth_bootdev           |   |       |--
> ethernet at 30be0000.bootdev
>  mdio          0  [ + ]   fec_mdio              |   |       `-- mdio
>  dsa           0  [   ]   mv88e6xxx             |   |           `-- switch at 0
>  ethernet      1  [   ]   dsa-port              |   |               |-- lan4
>  bootdev       3  [   ]   eth_bootdev           |   |               |
>  `-- switch at 0@0.bootdev
>  ethernet      2  [   ]   dsa-port              |   |               |-- lan3
>  bootdev       4  [   ]   eth_bootdev           |   |               |
>  `-- switch at 0@1.bootdev
>  ethernet      3  [   ]   dsa-port              |   |               |-- lan2
>  bootdev       5  [   ]   eth_bootdev           |   |               |
>  `-- switch at 0@2.bootdev
>  ethernet      4  [   ]   dsa-port              |   |               |-- lan1
>  bootdev       6  [   ]   eth_bootdev           |   |               |
>  `-- switch at 0@3.bootdev
>  mdio          1  [ + ]   mv88e6xxx_mdio        |   |
> |-- mv88e6xxx-mdio-0
>  mdio          2  [   ]   mv88e6xxx_mdio        |   |
> |-- mv88e6xxx-mdio-1
>  mdio          3  [   ]   mv88e6xxx_mdio        |   |
> |-- mv88e6xxx-mdio-2
>  mdio          4  [   ]   mv88e6xxx_mdio        |   |
> `-- mv88e6xxx-mdio-3
>
> but still not able to get a DHCP address:
>
> u-boot=> dhcp
> BOOTP broadcast 1
> BOOTP broadcast 2
> BOOTP broadcast 3
> BOOTP broadcast 4

With CONFIG_CMD_NET=y what does 'net list' show?

I have the following (with network attached to lan4 port)
Net:   MV88E61XX eth0: ethernet at 2188000, eth1: lan4, eth2: lan3, eth3: lan2, eth
4: lan1
Hit any key to stop autoboot:  0
Ventana > print ethaddr
ethaddr=00:d0:12:f3:f2:f5
Ventana > dm tree
...
 ethernet      0  [ + ]   fecmxc                |   |   |-- ethernet at 2188000
 bootdev       0  [   ]   eth_bootdev           |   |   |   |--
ethernet at 2188000.bootdev
 mdio          0  [ + ]   fec_mdio              |   |   |   `-- mdio
 dsa           0  [ + ]   mv88e6xxx             |   |   |       `-- switch at 0
 ethernet      1  [ + ]   dsa-port              |   |   |           |-- lan4
 bootdev       2  [   ]   eth_bootdev           |   |   |           |
 `-- switch at 0@0.bootdev
 ethernet      2  [ + ]   dsa-port              |   |   |           |-- lan3
 bootdev       3  [   ]   eth_bootdev           |   |   |           |
 `-- switch at 0@1.bootdev
 ethernet      3  [ + ]   dsa-port              |   |   |           |-- lan2
 bootdev       4  [   ]   eth_bootdev           |   |   |           |
 `-- switch at 0@2.bootdev
 ethernet      4  [ + ]   dsa-port              |   |   |           |-- lan1
 bootdev       5  [   ]   eth_bootdev           |   |   |           |
 `-- switch at 0@3.bootdev
 mdio          1  [ + ]   mv88e6xxx_mdio        |   |   |
`-- mv88e6xxx-mdio-0
...
Ventana > net list
eth0 : ethernet at 2188000 00:d0:12:f3:f2:f5 active
eth1 : lan4 00:d0:12:f3:f2:f5
eth2 : lan3 00:d0:12:f3:f2:f5
eth3 : lan2 00:d0:12:f3:f2:f5
eth4 : lan1 00:d0:12:f3:f2:f5
Ventana > setenv ethact lan4
Ventana > dhcp
BOOTP broadcast 1
BOOTP broadcast 2
BOOTP broadcast 3
DHCP client bound to address 172.24.33.142 (1076 ms)

I do not use CONFIG_NET_RANDOM_ETHADDR and have a single MAC address
allocated to the board.

What board are you using and what does its fec/mdio dt look like?

Best Regards,

Tim